fix: plotly regression

Author: hoxbro

panel/pane/plotly.py

@@ -159,20 +159,24 @@ def _update_figure(self):
         if (fig is None or isinstance(fig, (dict, list, tuple)) or fig is self._figure or not self.link_figure):
             return
 
-        # Monkey patch the message stubs used by FigureWidget.
-        if not hasattr(fig, '_send_addTraces_msg'):
+        def _from_plotly(attr):
+            mod_attr = getattr(fig, attr, None)
+            return mod_attr is None or getattr(mod_attr, "__module__", "").startswith('plotly')
+
+        # Monkey patch the message stubs used by FigureWidget, only if the method is from plotly
+        if _from_plotly('_send_addTraces_msg'):
             fig._send_addTraces_msg = lambda *_, **__: self._update_from_figure('add')
-        if not hasattr(fig, '_send_deleteTraces_msg'):
+        if _from_plotly('_send_deleteTraces_msg'):
             fig._send_deleteTraces_msg = lambda *_, **__: self._update_from_figure('delete')
-        if not hasattr(fig, '_send_moveTraces_msg'):
+        if _from_plotly('_send_moveTraces_msg'):
             fig._send_moveTraces_msg = lambda *_, **__: self._update_from_figure('move')
-        if not hasattr(fig, '_send_restyle_msg'):
+        if _from_plotly('_send_restyle_msg'):
             fig._send_restyle_msg = self._send_restyle_msg
-        if not hasattr(fig, '_send_relayout_msg'):
+        if _from_plotly('_send_relayout_msg'):
             fig._send_relayout_msg = self._send_relayout_msg
-        if not hasattr(fig, '_send_update_msg'):
+        if _from_plotly('_send_update_msg'):
             fig._send_update_msg = self._send_update_msg
-        if not hasattr(fig, '_send_animate_msg'):
+        if _from_plotly('_send_animate_msg'):
             fig._send_animate_msg = lambda *_, **__: self._update_from_figure('animate')
         self._figure = fig
 

panel/tests/ui/pane/test_plotly.py

@@ -274,6 +274,49 @@ def test_plotly_select_data(page, plotly_2d_plot):
 
 
 
+def test_plotly_click_data_add_trace(page):
+    # Regression test for https://github.com/holoviz/panel/issues/8470
+    fig = go.Figure()
+    fig.add_trace(go.Scatter(x=[0, 1, 2, 3], y=[0, 1, 2, 3], mode='markers'))
+    fig.update_layout(uirevision='keep')
+
+    pane = Plotly(fig)
+
+    def on_click(event):
+        if event.new is None:
+            return
+        pt = event.new['points'][0]
+        fig.add_trace(go.Scatter(
+            x=[pt['x']], y=[pt['y']], mode='markers', showlegend=False,
+        ))
+
+    pane.param.watch(on_click, 'click_data')
+
+    serve_component(page, pane)
+
+    point = page.locator('.js-plotly-plot path.point').first
+    expect(point).to_be_visible()
+
+    for _ in range(3):
+        point.click(force=True)
+        page.wait_for_timeout(100)
+
+    GET_TRACE_COUNT_JS = """() => {
+        function find(root) {
+          for (const d of root.querySelectorAll('div')) {
+            if (d.data && Array.isArray(d.data)) return d.data.length;
+          }
+          for (const el of root.querySelectorAll('*')) {
+            if (el.shadowRoot) { const r = find(el.shadowRoot); if (r !== null) return r; }
+          }
+          return null;
+        }
+        return find(document);
+    }"""
+
+    wait_until(lambda: page.evaluate(GET_TRACE_COUNT_JS) > 1, page)
+
+
 def test_plotly_img_plot(page, plotly_img_plot):
     msgs, _ = serve_component(page, plotly_img_plot)