Skip to content

Commit 146128c

Browse files
committed
Merge remote-tracking branch 'upstream/main' into fix-slider-coloring-issue
2 parents 4bfa689 + 8644d22 commit 146128c

12 files changed

Lines changed: 692 additions & 1064 deletions

.github/pull_request_template.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
## Description
2+
3+
<!--
4+
- Summarize the change and which issue is fixed.
5+
- Include relevant motivation and context.
6+
- Add visuals when possible, e.g. before/after screenshots with full code snippets.
7+
-->
8+
9+
Fixes #{issue}
10+
11+
## How Has This Been Tested?
12+
13+
<!-- Describe the tests that you ran to verify your changes. Provide instructions so it can be reproduced while reviewing your changes. -->
14+
15+
## AI Disclosure
16+
17+
<!-- Remove this section if your PR does not contain AI-generated content. -->
18+
19+
- [ ] This PR contains AI-generated content.
20+
- [ ] I have tested all AI-generated content in my PR.
21+
- [ ] I take responsibility for all AI-generated content in my PR.
22+
<!-- If you used AI to generate code, please specify the tool and model used, and how you have used it. -->
23+
Tools: {e.g., Claude, Codex, GitHub Copilot, ChatGPT, etc.}
24+
25+
## Checklist
26+
27+
<!-- Remove the non relevant items. -->
28+
29+
- [ ] Tests added and is passing
30+
- [ ] Added documentation

.pre-commit-config.yaml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ repos:
1616
- repo: https://github.com/astral-sh/ruff-pre-commit
1717
rev: v0.14.10
1818
hooks:
19-
- id: ruff
19+
- id: ruff-check
2020
files: panel/
2121
- repo: https://github.com/pycqa/isort
2222
rev: 7.0.0
@@ -47,15 +47,16 @@ repos:
4747
- id: oxipng
4848
stages: [manual]
4949
- repo: https://github.com/pre-commit/mirrors-eslint
50-
rev: v9.37.0
50+
rev: v9.39.1
5151
hooks:
5252
- id: eslint
53-
args: ['-c', 'panel/.eslintrc.js', 'panel/*.ts', 'panel/models/**/*.ts', '--fix']
53+
args: ['--config', 'panel/eslint.config.js', 'panel/*.ts', 'panel/models/**/*.ts', '--fix']
5454
additional_dependencies:
55-
- 'eslint@8.57.0'
56-
- '@stylistic/eslint-plugin@1.6.3'
57-
- '@typescript-eslint/eslint-plugin@7.2.0'
58-
- '@typescript-eslint/parser@7.2.0'
55+
- 'eslint@9.39.1'
56+
- '@stylistic/eslint-plugin@5.9.0'
57+
- '@typescript-eslint/eslint-plugin@8.56.1'
58+
- '@typescript-eslint/parser@8.56.1'
59+
- 'typescript-eslint@8.56.1'
5960
ci:
6061
autofix_prs: false
6162
autoupdate_schedule: quarterly

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
## Version 1.8.8
44

5-
Panel 1.8.8 focuses on stability, event handling correctness, Pyodide improvements, ESM robustness, and multiple UI fixes. It also introduces a new experimental `freeze` option for `hold()` to improve performance during batch updates. Many thanks to the contributors to this release including:
6-
@philippjfr, @SumaiyaIslam, @emunsing, @AtharvaJaiswal005, @DevilSpecial, @DanielAlanBates, @FlorianVerdonck, @ahuang11, @SimonHeybrock, @Coderambling, and @MarcSkovMadsen.
5+
Panel 1.8.8 focuses on stability, event handling correctness, Pyodide improvements, ESM robustness, and multiple UI fixes. It also introduces a new experimental `freeze` option for `hold()` to improve performance during batch updates.
6+
Many thanks to [@AR21SM](https://github.com/AR21SM) (first contribution), [@AtharvaJaiswal005](https://github.com/AtharvaJaiswal005) (first contribution), [@danielalanbates](https://github.com/danielalanbates) (first contribution), [@DevilSpecial](https://github.com/DevilSpecial) (first contribution), [@emunsing](https://github.com/emunsing) (first contribution), [@nojaf](https://github.com/nojaf) (first contribution), [@SimonHeybrock](https://github.com/SimonHeybrock) (first contribution), [@SuMayaBee](https://github.com/SuMayaBee) (first contribution), [@ahuang11](https://github.com/ahuang11), [@Coderambling](https://github.com/Coderambling), [@philippjfr](https://github.com/philippjfr), and [@hoxbro](https://github.com/hoxbro) for their contributions.
77

88
### ✨ Enhancements
99

doc/about/releases.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
## Version 1.8.8
44

5-
Panel 1.8.8 focuses on stability, event handling correctness, Pyodide improvements, ESM robustness, and multiple UI fixes. It also introduces a new experimental `freeze` option for `hold()` to improve performance during batch updates. Many thanks to the contributors to this release including:
6-
@philippjfr, @SumaiyaIslam, @emunsing, @AtharvaJaiswal005, @DevilSpecial, @DanielAlanBates, @FlorianVerdonck, @ahuang11, @SimonHeybrock, @Coderambling, and @MarcSkovMadsen.
5+
Panel 1.8.8 focuses on stability, event handling correctness, Pyodide improvements, ESM robustness, and multiple UI fixes. It also introduces a new experimental `freeze` option for `hold()` to improve performance during batch updates.
6+
Many thanks to [@AR21SM](https://github.com/AR21SM) (first contribution), [@AtharvaJaiswal005](https://github.com/AtharvaJaiswal005) (first contribution), [@danielalanbates](https://github.com/danielalanbates) (first contribution), [@DevilSpecial](https://github.com/DevilSpecial) (first contribution), [@emunsing](https://github.com/emunsing) (first contribution), [@nojaf](https://github.com/nojaf) (first contribution), [@SimonHeybrock](https://github.com/SimonHeybrock) (first contribution), [@SuMayaBee](https://github.com/SuMayaBee) (first contribution), [@ahuang11](https://github.com/ahuang11), [@Coderambling](https://github.com/Coderambling), [@philippjfr](https://github.com/philippjfr), and [@hoxbro](https://github.com/hoxbro) for their contributions.
77

88
### ✨ Enhancements
99

panel/.eslintrc.js

Lines changed: 0 additions & 129 deletions
This file was deleted.

panel/eslint.config.js

Lines changed: 140 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,140 @@
1+
const tseslint = require("typescript-eslint")
2+
const stylistic = require("@stylistic/eslint-plugin")
3+
4+
module.exports = tseslint.config(
5+
{
6+
ignores: [
7+
"**/dist/**",
8+
"**/theme/**/*.js",
9+
"eslint.config.js",
10+
"**/_templates/*.js",
11+
"**/template/**/*.js",
12+
"examples/**",
13+
"scripts/**",
14+
"doc/_static/*.js",
15+
],
16+
},
17+
{
18+
files: ["**/*.ts", "**/*.tsx"],
19+
plugins: {
20+
"@typescript-eslint": tseslint.plugin,
21+
"@stylistic": stylistic,
22+
},
23+
languageOptions: {
24+
parser: tseslint.parser,
25+
parserOptions: {
26+
project: ["./tsconfig.json"],
27+
tsconfigRootDir: __dirname,
28+
sourceType: "module",
29+
},
30+
},
31+
rules: {
32+
"@typescript-eslint/consistent-type-assertions": "error",
33+
"@typescript-eslint/consistent-type-imports": ["error", {
34+
prefer: "type-imports",
35+
fixStyle: "separate-type-imports",
36+
}],
37+
"@typescript-eslint/no-unnecessary-condition": ["warn", {allowConstantLoopConditions: true}],
38+
"@typescript-eslint/strict-boolean-expressions": ["warn", {
39+
allowAny: true,
40+
allowString: false,
41+
allowNumber: false,
42+
allowNullableObject: false,
43+
allowNullableBoolean: false,
44+
allowNullableString: false,
45+
allowNullableNumber: false,
46+
}],
47+
"@typescript-eslint/no-unnecessary-type-assertion": ["error"],
48+
"@typescript-eslint/no-unnecessary-type-constraint": ["error"],
49+
"@typescript-eslint/switch-exhaustiveness-check": ["error"],
50+
"@typescript-eslint/no-floating-promises": ["warn", {ignoreVoid: true}],
51+
"no-console": ["error", {allow: ["warn", "error"]}],
52+
"no-self-assign": ["error", {props: false}],
53+
"brace-style": ["error", "1tbs", {allowSingleLine: true}],
54+
"comma-dangle": ["off"],
55+
"@stylistic/comma-dangle": ["error", {
56+
arrays: "always-multiline",
57+
objects: "always-multiline",
58+
imports: "always-multiline",
59+
exports: "always-multiline",
60+
functions: "always-multiline",
61+
enums: "always-multiline",
62+
generics: "always-multiline",
63+
tuples: "always-multiline",
64+
}],
65+
"comma-spacing": ["error", {before: false, after: true}],
66+
"dot-notation": "error",
67+
"eol-last": ["error", "always"],
68+
"no-irregular-whitespace": ["error"],
69+
"@stylistic/indent": ["error", 2, {
70+
SwitchCase: 1,
71+
outerIIFEBody: 1,
72+
ArrayExpression: "first",
73+
ObjectExpression: "first",
74+
ImportDeclaration: "first",
75+
VariableDeclarator: "first",
76+
CallExpression: {arguments: 1},
77+
FunctionDeclaration: {body: 1, parameters: "off"},
78+
FunctionExpression: {body: 1, parameters: "off"},
79+
ignoredNodes: ["ConditionalExpression"],
80+
}],
81+
"@stylistic/no-mixed-spaces-and-tabs": ["error"],
82+
"@stylistic/member-delimiter-style": ["error", {
83+
multiline: {
84+
delimiter: "none",
85+
requireLast: true,
86+
},
87+
singleline: {
88+
delimiter: "comma",
89+
requireLast: false,
90+
},
91+
}],
92+
"@stylistic/semi": ["error", "never"],
93+
"@stylistic/type-annotation-spacing": ["error"],
94+
"no-debugger": "error",
95+
"no-floating-decimal": ["error"],
96+
"no-multiple-empty-lines": ["error", {max: 1, maxBOF: 0, maxEOF: 0}],
97+
"no-new-wrappers": "error",
98+
"no-throw-literal": "error",
99+
"no-trailing-spaces": ["error"],
100+
"no-var": "error",
101+
"object-shorthand": "error",
102+
"prefer-const": ["error", {destructuring: "all"}],
103+
"prefer-exponentiation-operator": "error",
104+
"quote-props": ["error", "as-needed"],
105+
"object-curly-spacing": ["error", "never"],
106+
"space-before-blocks": ["error", "always"],
107+
"space-before-function-paren": ["error", {
108+
anonymous: "never",
109+
named: "never",
110+
asyncArrow: "always",
111+
}],
112+
"space-in-parens": ["error", "never"],
113+
"keyword-spacing": ["error", {before: true, after: true}],
114+
"func-call-spacing": ["error", "never"],
115+
"no-whitespace-before-property": ["error"],
116+
"block-spacing": ["error", "always"],
117+
"key-spacing": ["error", {
118+
beforeColon: false,
119+
afterColon: true,
120+
mode: "minimum",
121+
}],
122+
"space-unary-ops": ["error", {
123+
words: true,
124+
nonwords: false,
125+
overrides: {},
126+
}],
127+
"guard-for-in": ["warn"],
128+
"quotes": ["error", "double", {avoidEscape: true, allowTemplateLiterals: true}],
129+
"curly": ["error", "all"],
130+
"prefer-template": ["error"],
131+
"generator-star-spacing": ["error", {
132+
before: false,
133+
after: true,
134+
anonymous: {before: false, after: true},
135+
method: {before: true, after: false},
136+
}],
137+
"yield-star-spacing": ["error", {before: false, after: true}],
138+
},
139+
},
140+
)

panel/models/layout.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,9 @@ export function set_size(el: HTMLElement, model: HTMLBox, adjust_margin: boolean
115115
height_policy = "max"
116116
break
117117
}
118+
case "inherit": {
119+
break
120+
}
118121
default: {
119122
unreachable()
120123
}

panel/models/lumagl.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// SPDX-License-Identifier: MIT
33
// Copyright (c) vis.gl contributors
44

5-
/* eslint-disable key-spacing, max-len, no-inline-comments, camelcase */
6-
75
/**
86
* Standard WebGL, WebGL2 and extension constants (OpenGL constants)
97
* @note (Most) of these constants are also defined on the WebGLRenderingContext interface.

0 commit comments

Comments
 (0)