linting and ci fixes

Author: hill

.github/workflows/ci.yml

@@ -3,6 +3,8 @@ name: CI
 on:
   push:
     branches: [ main, master ]
+    tags:
+      - "v*"
   pull_request:
     branches: [ main, master ]
 
@@ -17,8 +19,12 @@ jobs:
     - run: cargo clippy -- -D warnings
     - run: cargo fmt --check
 
-  build:
+  release:
+    # Only run when a tag push triggers the workflow
+    if: startsWith(github.ref, 'refs/tags/')
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
     steps:
     - uses: actions/checkout@v4
     - uses: taiki-e/upload-rust-binary-action@v1
@@ -28,4 +34,4 @@ jobs:
         archive: $bin-$target
         checksum: sha256
       env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -1 +1,2 @@
 /target
+.DS_Store

README.md

@@ -4,18 +4,20 @@
 [![Crates.io](https://img.shields.io/crates/v/lazyslurm.svg)](https://crates.io/crates/lazyslurm)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 
-A terminal UI for [SLURM](https://slurm.schedmd.com/overview.html) job management. Like the awesome [lazygit](https://github.com/jesseduffield/lazygit) but for HPC clusters.
+A terminal UI for [slurm](https://slurm.schedmd.com/overview.html) job management. Like the awesome [lazygit](https://github.com/jesseduffield/lazygit) but for HPC clusters.
 
 ![LazySlurm Screenshot](screenshot.png)
 
+## Why This Exists
+
+Slurm's CLI is powerful but clunky for monitoring. This project gives you the lazygit experience.
+Built in Rust with ratatui because single binaries are beautiful on HPC systems.
+
 ## Features
 
-- **Real-time job monitoring** - Watch your jobs as they run, with live log tailing
-- **Intuitive keyboard navigation** - Vim-like controls for efficiency  
 - **Job management** - Cancel jobs, view details, and monitor resource usage
-- **Cross-platform** - Works on Linux, macOS, and Windows
 - **Single binary** - No dependencies, perfect for HPC environments
-- **Lightweight** - Fast startup, minimal resource usage
+- **Real-time job monitoring** - Watch your jobs as they run, with live log tailing
 
 ## Installation
 
@@ -116,10 +118,4 @@ cargo run
 just slurm_populate
 ```
 
-Your source code is mounted into the container so changes are immediately available.
-
-## Why This Exists
-
-SLURM's CLI is powerful but clunky for monitoring. This gives you the lazygit experience: see state, take actions, see new state. Real-time updates, keyboard navigation, visual feedback.
-
-Built in Rust with ratatui because single binaries are beautiful on HPC systems.
+Your source code is mounted into the container so changes are immediately available.

justfile

@@ -38,6 +38,9 @@ slurm_down:
 test:
     cargo test
 
+# Lint with Clippy
+lint:
+    cargo clippy -- -D warnings
 # Clean up everything
 clean:
     cd dev && docker-compose down -v

src/main.rs

@@ -59,8 +59,7 @@ async fn run_app(
 
         // Handle events with timeout
         let timeout = Duration::from_millis(250);
-        if crossterm::event::poll(timeout)? {
-            if let Event::Key(key) = event::read()? {
+        if crossterm::event::poll(timeout)? && let Event::Key(key) = event::read()? {
                 // Only handle KeyEventKind::Press to avoid duplicate events
                 if key.kind != KeyEventKind::Press {
                     continue;
@@ -84,7 +83,6 @@ async fn run_app(
                     }
                     _ => {}
                 }
-            }
         }
 
         // Auto refresh if needed

src/models/job.rs

@@ -163,4 +163,10 @@ impl JobList {
     pub fn completed_jobs(&self) -> Vec<&Job> {
         self.jobs.iter().filter(|job| job.is_completed()).collect()
     }
-}
+}
+
+impl Default for JobList {
+    fn default() -> Self {
+        Self::new()
+    }
+}

src/slurm/parser.rs

@@ -152,10 +152,8 @@ impl SlurmParser {
         }
 
         // Secondary: Use StdErr if different
-        if let Some(std_err) = &job.std_err {
-            if Some(std_err) != job.std_out.as_ref() {
-                paths.push(std_err.clone());
-            }
+        if let Some(std_err) = &job.std_err && Some(std_err) != job.std_out.as_ref() {
+            paths.push(std_err.clone());
         }
 
         // Fallback: Common SLURM default patterns in working directory
@@ -174,4 +172,4 @@ impl SlurmParser {
 
         paths
     }
-}
+}

src/ui/app.rs

@@ -70,10 +70,10 @@ impl App {
 
         // For each job, get detailed info from scontrol (but only for first few to avoid overwhelming)
         for job in jobs.iter_mut().take(10) {
-            if let Ok(scontrol_output) = SlurmCommands::scontrol_show_job(&job.job_id).await {
-                if let Ok(fields) = SlurmParser::parse_scontrol_output(&scontrol_output) {
-                    SlurmParser::enhance_job_with_scontrol_data(job, fields);
-                }
+            if let Ok(scontrol_output) = SlurmCommands::scontrol_show_job(&job.job_id).await
+                && let Ok(fields) = SlurmParser::parse_scontrol_output(&scontrol_output)
+            {
+                SlurmParser::enhance_job_with_scontrol_data(job, fields);
             }
         }
 
@@ -135,4 +135,10 @@ impl App {
     pub async fn receive_event(&mut self) -> Option<AppEvent> {
         self.event_receiver.recv().await
     }
-}
+}
+
+impl Default for App {
+    fn default() -> Self {
+        Self::new()
+    }
+}

src/ui/components.rs

@@ -57,7 +57,7 @@ pub fn render_app(frame: &mut Frame, app: &App) {
 }
 
 fn render_status_bar(frame: &mut Frame, app: &App, area: Rect) {
-    let mut status_text = format!("LazySlurm");
+    let mut status_text = "LazySlurm".to_string();
 
     if let Some(user) = &app.current_user {
         status_text.push_str(&format!(" - User: {}", user));
@@ -303,4 +303,4 @@ fn truncate(s: &str, max_len: usize) -> String {
     } else {
         format!("{}...", &s[..max_len.saturating_sub(3)])
     }
-}
+}