Suppress some of the warning reported by the eclipse compiler

Author: marko-bekhta

integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/extension/SearchSetupHelper.java

@@ -257,6 +257,7 @@ public PartialSetup setupFirstPhaseOnly() {
 			return setupFirstPhaseOnly( Optional.empty() );
 		}
 
+		@SuppressWarnings("resource") // For the eclipse-compiler: complains on StubMappingImpl not bing closed
 		public PartialSetup setupFirstPhaseOnly(Optional<StubMapping> previousMapping) {
 			Context context = currentContext();
 			SearchIntegrationEnvironment environment =

integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/testsupport/index/AbstractBackendHolder.java

@@ -44,6 +44,7 @@ public abstract class AbstractBackendHolder {
 	private List<MappedIndex> indexes;
 
 	@Setup(Level.Trial)
+	@SuppressWarnings("resource") // For the eclipse-compiler: complains on StubMappingImpl not bing closed
 	public void startHibernateSearch(TemporaryFileHolder temporaryFileHolder) throws IOException {
 		Map<String, Object> baseProperties = new LinkedHashMap<>();
 

mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/DefaultIdentifierBindingContext.java

@@ -57,9 +57,10 @@ public <I2> void bridge(Class<I2> expectedValueType, IdentifierBridge<I2> bridge
 	}
 
 	@Override
+	@SuppressWarnings("resource") // For the eclipse-compiler: complains on bridge not bing closed
 	public <I2> void bridge(Class<I2> expectedValueType, BeanHolder<? extends IdentifierBridge<I2>> bridgeHolder) {
+		PojoRawTypeModel<I2> expectedValueTypeModel = introspector.typeModel( expectedValueType );
 		try {
-			PojoRawTypeModel<I2> expectedValueTypeModel = introspector.typeModel( expectedValueType );
 			if ( !identifierTypeModel.rawType().equals( expectedValueTypeModel ) ) {
 				throw log.invalidInputTypeForBridge( bridgeHolder.get(), identifierTypeModel, expectedValueTypeModel );
 			}

mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/PropertyBindingContextImpl.java

@@ -126,6 +126,7 @@ public Optional<BoundPropertyBridge<P>> applyBinder(PropertyBinder binder) {
 		}
 	}
 
+	@SuppressWarnings("resource") // For the eclipse-compiler: complains on bridge not bing closed
 	private <P2> void checkAndBind(BeanHolder<? extends PropertyBridge<P2>> bridgeHolder,
 			PojoRawTypeModel<?> expectedPropertyTypeModel) {
 		if ( !propertyTypeModel.rawType().isSubTypeOf( expectedPropertyTypeModel ) ) {

mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/RoutingBindingContextImpl.java

@@ -53,7 +53,9 @@ public <E2> void bridge(Class<E2> expectedType, RoutingBridge<E2> bridge) {
 	}
 
 	@Override
-	@SuppressWarnings("unchecked") // Checked using reflection
+	@SuppressWarnings({
+			"unchecked" /*Checked using reflection*/,
+			"resource" /* For the eclipse-compiler: complains on bridge not bing closed */ })
 	public <E2> void bridge(Class<E2> expectedType, BeanHolder<? extends RoutingBridge<E2>> bridgeHolder) {
 		PojoRawTypeModel<E2> expectedTypeModel = introspector.typeModel( expectedType );
 		if ( !indexedEntityType.isSubTypeOf( expectedTypeModel ) ) {

mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/TypeBindingContextImpl.java

@@ -126,6 +126,7 @@ public Optional<BoundTypeBridge<T>> applyBinder(TypeBinder binder) {
 		}
 	}
 
+	@SuppressWarnings("resource") // For the eclipse-compiler: complains on bridge not bing closed
 	private <T2> void checkAndBind(BeanHolder<? extends TypeBridge<T2>> bridgeHolder,
 			PojoRawTypeModel<?> expectedPropertyTypeModel) {
 		if ( !typeModel.rawType().isSubTypeOf( expectedPropertyTypeModel ) ) {

mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/binding/impl/ValueBindingContextImpl.java

@@ -89,6 +89,7 @@ public <V2, F> void bridge(Class<V2> expectedValueType, ValueBridge<V2, F> bridg
 	}
 
 	@Override
+	@SuppressWarnings("resource") // For the eclipse-compiler: complains on bridge not bing closed
 	public <V2, F> void bridge(Class<V2> expectedValueType, BeanHolder<? extends ValueBridge<V2, F>> bridgeHolder,
 			IndexFieldTypeOptionsStep<?, F> fieldTypeOptionsStep) {
 		try {

mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/bridge/runtime/impl/RoutingBridgeDocumentRouter.java

@@ -70,6 +70,7 @@ private final class CurrentDocumentRoutes implements DocumentRoutes {
 		private boolean skip = false;
 
 		@Override
+		@SuppressWarnings("resource") // For the eclipse-compiler: complains on bridge not bing closed
 		public DocumentRoute addRoute() {
 			if ( currentRoute != null ) {
 				// TODO HSEARCH-3971 allow routing to multiple indexes *simultaneously*?
@@ -84,6 +85,7 @@ public void notIndexed() {
 			skip = true;
 		}
 
+		@SuppressWarnings("resource") // For the eclipse-compiler: complains on bridge not bing closed
 		DocumentRouteDescriptor currentRoute(Object entityIdentifier, E entity, BridgeSessionContext context) {
 			routingBridgeHolder.get()
 					.route( this, entityIdentifier, entity, context.routingBridgeRouteContext() );
@@ -117,6 +119,7 @@ public void notIndexed() {
 			skip = true;
 		}
 
+		@SuppressWarnings("resource") // For the eclipse-compiler: complains on bridge not bing closed
 		Collection<DocumentRouteDescriptor> previousDifferentRoutes(DocumentRouteDescriptor currentRoute,
 				Object entityIdentifier, E entity, DocumentRoutesDescriptor providedRoutes, BridgeSessionContext context) {
 			routingBridgeHolder.get()

mapper/pojo-standalone/src/main/java/org/hibernate/search/mapper/pojo/standalone/bootstrap/impl/StandalonePojoIntegrationPartialBuildState.java

@@ -66,6 +66,7 @@ StandalonePojoMapping doBootSecondPhase(ConfigurationPropertySource propertySour
 			ConfigurationPropertyChecker propertyChecker) {
 		SearchIntegrationFinalizer finalizer = integrationBuildState.finalizer( propertySource, propertyChecker );
 
+		@SuppressWarnings("resource") // For the eclipse-compiler: complains on mapping not bing closed
 		StandalonePojoMapping mapping = finalizer.finalizeMapping(
 				mappingKey,
 				(context, partialMapping) -> partialMapping.finalizeMapping( context )

util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/extension/VerifyingStubBackendBehavior.java

@@ -401,6 +401,7 @@ public long executeCountWork(Set<String> indexNames) {
 	}
 
 	@Override
+	@SuppressWarnings("resource") // For the eclipse-compiler: complains on StubSearchScroll not bing closed
 	public <T> SearchScroll<T> executeScrollWork(Set<String> indexNames, StubSearchWork work, int chunkSize,
 			StubSearchProjectionContext projectionContext, SearchLoadingContext<?> loadingContext,
 			StubSearchProjection<T> rootProjection, TimingSource timingSource) {