From d55d4f598cd5a5c7b03baac785b562157eaf87c4 Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Wed, 16 Jun 2021 08:21:28 +0200 Subject: [PATCH 1/3] Add manual upload instructions --- docs/releases.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/releases.md b/docs/releases.md index 5378986d2c..48296e57ad 100644 --- a/docs/releases.md +++ b/docs/releases.md @@ -85,9 +85,16 @@ we make sure to upload them as their full name variant. If the workflow fail and all of some binaries has not been uploaded, the prerelease and the tag itself has to be recreated to start it again. -If only some of the artefacts are missinf an alternative could be make +If only some of the artefacts are missing, an alternative could be make the release in a fork and upload manually them. +To manually upload the missing binary we should: + +- Add the new tar/zip following the name conventions of existing ones + - `haskell-language-server-${os}-${ghcVersion}.gz` for `Linux` and `macOS` and `haskell-language-server-Windows-${ghcVersion}.exe.zip` for `Windows` + - the binary inside the gz file is named `haskell-language-server-${ghcVersion}` (with the `.exe` extension for `Windows`). Note that the binary name does not contain the `${os}`part. +- Add the executable to the existing tar `haskell-language-server-${os}-${ghcVersion}.tar.gz` following the same schema for the binary as the previous one. + ### ghcup Ghcup can install hls binaries, provided that there is a tarfile called `haskell-language-server-{macOS,Linux}-$HLS_VERSION.tar.gz` From 383981dbc77a0ccab815b4e43859af58a23c7634 Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Wed, 16 Jun 2021 08:24:09 +0200 Subject: [PATCH 2/3] Add the local build case --- docs/releases.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/releases.md b/docs/releases.md index 48296e57ad..b0e4d95f32 100644 --- a/docs/releases.md +++ b/docs/releases.md @@ -88,6 +88,8 @@ the prerelease and the tag itself has to be recreated to start it again. If only some of the artefacts are missing, an alternative could be make the release in a fork and upload manually them. +If they are missing due to ci specific problems we can build the executable locally. + To manually upload the missing binary we should: - Add the new tar/zip following the name conventions of existing ones From 7d1c7e68282482c7975855d0ab9f5786c6177f18 Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Wed, 16 Jun 2021 08:32:30 +0200 Subject: [PATCH 3/3] Add missing whitespace --- docs/releases.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/releases.md b/docs/releases.md index b0e4d95f32..a947cb4c8b 100644 --- a/docs/releases.md +++ b/docs/releases.md @@ -94,7 +94,7 @@ To manually upload the missing binary we should: - Add the new tar/zip following the name conventions of existing ones - `haskell-language-server-${os}-${ghcVersion}.gz` for `Linux` and `macOS` and `haskell-language-server-Windows-${ghcVersion}.exe.zip` for `Windows` - - the binary inside the gz file is named `haskell-language-server-${ghcVersion}` (with the `.exe` extension for `Windows`). Note that the binary name does not contain the `${os}`part. + - the binary inside the gz file is named `haskell-language-server-${ghcVersion}` (with the `.exe` extension for `Windows`). Note that the binary name does not contain the `${os}` part. - Add the executable to the existing tar `haskell-language-server-${os}-${ghcVersion}.tar.gz` following the same schema for the binary as the previous one. ### ghcup