Skip to content

Do not error out on failed rewrite #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2021
Merged

Do not error out on failed rewrite #1269

merged 1 commit into from
Jan 28, 2021

Conversation

pepeiborra
Copy link
Collaborator

The error call was only for diagnostics, so I have replaced
it with a debug trace (commented out)

@pepeiborra
Do not error out on failed rewrite
983f052 
The error call was only for diagnostics, so I have replaced
it with a debug trace (commented out)
@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Jan 28, 2021
@mergify mergify bot merged commit 6559416 into master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndmitchell ndmitchell ndmitchell approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepeiborra @ndmitchell