stacks: Add local values walk to walk_dynamic #37980
Merged
+119
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps us catch diagnostics in locals that only happen during evaluation Co-authored-by: Mutahhir Hayat <[email protected]> Co-authored-by: Matej Risek <[email protected]>
nfagerlund
previously approved these changes
Dec 9, 2025
Member
nfagerlund
left a comment
nfagerlund
left a comment
There was a problem hiding this comment.
Omg awesome, I was hoping you'd be able to track down a way to interrupt this.
I went ahead and re-ran my reproduction case, and sure enough, the plan errored and spewed the same list of errors I saw from the modules runtime into the diagnostics. I was unable to proceed to an apply and corrupt the state.
The empty state thing still definitely deserves love, but this definitely fixes the one cause of it that we've been able to observe.
Contributor
Author
|
@nfagerlund I'll also look into the state issue and in inputs being unknown to make sure no other way can lead to a similar issue |
Contributor
Author
|
@nfagerlund This PR should fix the state issues: #37981 |
3 tasks
jbardin
previously approved these changes
Dec 10, 2025
DanielMSchmidt
added
the
1.14-backport
DanielMSchmidt
dismissed stale reviews from jbardin and nfagerlund
via
e02f8b4
dsa0x
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us surface issues where we can only notice problems with local values in the stacks component language during the evaluation of the value.
Co-authored-by: Mutahhir Hayat [email protected]
Co-authored-by: Matej Risek [email protected]
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry