PSS: Add tests showing provider commands being used with PSS
#37959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
force-pushed
the
pss/pss-with-state-commands
branch
3 times, most recently
from
bb7d519 to
c2d9c42
Compare
…ers` command Note: I've excluded the `terraform providers locks` and `terraform providers mirror` commands as they don't interact with backends.
SarahFrench
force-pushed
the
pss/pss-with-provider-commands
branch
from
1ab5e53 to
f9d9db3
Compare
Member
Author
|
See d19eb83 |
… `providers` command
… `providers schema` command
…halled into JSON output
…ed from `providers schema`.
SarahFrench
force-pushed
the
pss/pss-with-provider-commands
branch
from
d908507 to
b31ec3e
Compare
…ider schema output
… testing use of a state store to access and use state when generating output. This complements TestProvidersSchema that tests that state stores in a provider are reflected in the JSON representations of the schemas that the command returns.
radeksimko
previously approved these changes
Dec 17, 2025
Comment on lines
+38
to
+53
| "state_store_schemas": { | ||
| "test_store": { | ||
| "version": 0, | ||
| "block": { | ||
| "attributes": { | ||
| "value": { | ||
| "description_kind": "plain", | ||
| "required": true, | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "description_kind": "plain" | ||
| } | ||
| } | ||
| } | ||
| }, |
Member
There was a problem hiding this comment.
I don't know where to best track this (Jira?) but I think we should also draft a PR to terraform-json that reflects this change.
Member
Author
There was a problem hiding this comment.
Ah of course! I'll make a GitHub issue and link to it from Jira. Thanks for remembering that
Member
Author
|
It pained me to dismiss an approval 😭 but I realised in this PR I updated |
mildwonkey
approved these changes
Dec 17, 2025
Member
Author
|
Thanks @mildwonkey ! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #37569, this PR demonstrates that the
providercommands -that interact with backends- work when pluggable state storage is in use.The E2E test is intended to just test that the command can access state via a state store ok; thorough testing of the JSON representations of schemas is present in
TestProvidersSchemaand updated in this PR.The integration tests use an existing test fixture because some state_store config needs to be present for the test, but the state present in tests is contained within the mock provider definition.
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry