Skip to content

🐛 Fix missed postrender binary path arguments parsing#1534

Merged
arybolovlev merged 4 commits intomainfrom
fix-binary-path-args
Nov 14, 2024
Merged

🐛 Fix missed postrender binary path arguments parsing#1534
arybolovlev merged 4 commits intomainfrom
fix-binary-path-args

Conversation

@arybolovlev
Copy link
Collaborator

@arybolovlev arybolovlev commented Nov 14, 2024

Description

This is a quick fix to the issue where the postrender.args attribute is not parsed during creation. It was accidentally removed in this PR.

References

Fix: #1533

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev changed the title 🐛 Fix missed binary path arguments parsing 🐛 Fix missed postrender binary path arguments parsing Nov 14, 2024
@arybolovlev arybolovlev marked this pull request as ready for review November 14, 2024 09:56
@arybolovlev arybolovlev requested a review from a team as a code owner November 14, 2024 09:56
@github-actions github-actions bot added size/S and removed size/XS labels Nov 14, 2024
@@ -0,0 +1,3 @@
```release-note:bug
`resourehelm_release`: fix an issue where `postrender.args` is not parsed correctly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably typo resource.helm_release

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for noticing this. :-)

Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍

@arybolovlev arybolovlev merged commit 1156a26 into main Nov 14, 2024
@arybolovlev arybolovlev deleted the fix-binary-path-args branch November 14, 2024 17:22
@Reasonably Reasonably mentioned this pull request Nov 25, 2024
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

postrender ignores args since v2.15.0

3 participants