Fix nil pointer deref panic on helm_release destroy#1501
Merged
BBBmau merged 1 commit intohashicorp:mainfrom Oct 15, 2024
Merged
Fix nil pointer deref panic on helm_release destroy#1501BBBmau merged 1 commit intohashicorp:mainfrom
BBBmau merged 1 commit intohashicorp:mainfrom
Conversation
2b9f6ed to
aa8da65
Compare
The destroy panics when helm returns "release not found" as the returned response is nil.
aa8da65 to
e53e1b0
Compare
sheneska
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix nil pointer deref panic in
helm_resourceintroduced in2.16.0through GH-1487. This occurs, when the to-be-destroyed resource no more exists in K8s and helm returns "release not found" as the response is nil in this case.Fixes #1500
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note