Skip to content

Fix nil pointer deref panic on helm_release destroy#1501

Merged
BBBmau merged 1 commit intohashicorp:mainfrom
sbocinec:fix-nil-ptr-deref-destroy
Oct 15, 2024
Merged

Fix nil pointer deref panic on helm_release destroy#1501
BBBmau merged 1 commit intohashicorp:mainfrom
sbocinec:fix-nil-ptr-deref-destroy

Conversation

@sbocinec
Copy link
Contributor

@sbocinec sbocinec commented Oct 11, 2024

Description

Fix nil pointer deref panic in helm_resource introduced in 2.16.0 through GH-1487. This occurs, when the to-be-destroyed resource no more exists in K8s and helm returns "release not found" as the response is nil in this case.

Fixes #1500

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Fix helm_resource destroy panic when helm chart release is not found

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sbocinec sbocinec requested a review from a team as a code owner October 11, 2024 15:23
@sbocinec sbocinec force-pushed the fix-nil-ptr-deref-destroy branch from 2b9f6ed to aa8da65 Compare October 11, 2024 15:32
@sbocinec sbocinec changed the title Fix nil pointer deref panic in helm resource destroy Fix nil pointer deref panic on helm_release destroy Oct 11, 2024
The destroy panics when helm returns "release not found" as the returned
response is nil.
@BBBmau BBBmau merged commit 48730a7 into hashicorp:main Oct 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

helm provider 2.16.0 panics when destroy returns "release not found"

3 participants