Add new fields to release metadata, fix issue with test suite#1380
Merged
appilon merged 4 commits intohashicorp:mainfrom Jun 11, 2024
Merged
Add new fields to release metadata, fix issue with test suite#1380appilon merged 4 commits intohashicorp:mainfrom
appilon merged 4 commits intohashicorp:mainfrom
Conversation
appilon
suggested changes
Jun 7, 2024
Contributor
appilon
left a comment
There was a problem hiding this comment.
This looks good overall just need a few things changed to get it merged!
- Could you rebase to fix the conflicts in the go.mod/go.sum files
- Please add a file in
.changelog/PRnumber.txtthat details the change, you can see the most recent one as an example
Contributor
|
Since this PR was so well done I'm going to take the liberty of getting the PR unblocked. |
- last_deployed to implement hashicorp#1374 - first_deployed and notes to extend functionality further
tests that are using exec.Command to call helm CLI directly were expecting kubeconfig to be at KUBECONFIG, which may not be the same as KUBE_CONFIG_PATH
ba73075 to
0a952f7
Compare
appilon
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadataattribute by adding last deployed date #1374$KUBECONFIG, which may not be the same as$KUBE_CONFIG_PATH. The latter is explicitly expected by test suite for Terraform part.Description
Exposes more metadata about Helm release to extend the possibilities of other resources to act upon release changes. Additionally, provide primitive output from Helm deployment (rendered templates/NOTES.txt if available), which can be used with some bootstrap process.
In other words - adding missing data exposed by Helm.
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note