Allow Helm lookup in manifest experiment#1335
Merged
sheneska merged 2 commits intohashicorp:mainfrom Nov 5, 2024
Merged
Conversation
|
i've test your change @omgftw and it worked like a charm ! I was blocked between render my local chart and the need of aws-load-balancer-controller chart ! Hope they'll integrate this sooon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix is for the "manifest" experiment.
Some charts (notably
aws-load-balancer-controller) depend on Helm's lookup function to get data from certain resources. Often if they cannot get this data, they will generate new data (ex: a UUID). In this case, this will cause a permanent diff and you will not be able to upgrade the chart, since the plan will always change, resulting in a "Provider produced inconsistent final plan" error.To resolve this, I set the "DryRunOption" to "server". According to Helm's docs:
Acceptance tests
^ No, but I have tested the change manually.
Release Note
Release note for CHANGELOG:
References
#805
#711
Community Note