Skip to content

Allow Helm lookup in manifest experiment#1335

Merged
sheneska merged 2 commits intohashicorp:mainfrom
omgftw:dryrun-server
Nov 5, 2024
Merged

Allow Helm lookup in manifest experiment#1335
sheneska merged 2 commits intohashicorp:mainfrom
omgftw:dryrun-server

Conversation

@omgftw
Copy link
Contributor

@omgftw omgftw commented Feb 23, 2024

Description

This fix is for the "manifest" experiment.

Some charts (notably aws-load-balancer-controller) depend on Helm's lookup function to get data from certain resources. Often if they cannot get this data, they will generate new data (ex: a UUID). In this case, this will cause a permanent diff and you will not be able to upgrade the chart, since the plan will always change, resulting in a "Provider produced inconsistent final plan" error.

To resolve this, I set the "DryRunOption" to "server". According to Helm's docs:

Setting --dry-run==server will additionally execute any lookup in your chart towards the server.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
    ^ No, but I have tested the change manually.

Release Note

Release note for CHANGELOG:

NONE

References

#805
#711

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@omgftw omgftw requested a review from a team as a code owner February 23, 2024 08:20
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 23, 2024

CLA assistant check
All committers have signed the CLA.

@ThibaultSaillan
Copy link

i've test your change @omgftw and it worked like a charm ! I was blocked between render my local chart and the need of aws-load-balancer-controller chart ! Hope they'll integrate this sooon !

@BBBmau BBBmau self-assigned this Sep 10, 2024
Copy link
Collaborator

@sheneska sheneska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @omgftw! 🚀
Could you add a changelog please so we can go ahead and get this merged?

@sheneska sheneska merged commit 91a5cd1 into hashicorp:main Nov 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants