resolve version conflicts with local chart

[BBBmau]

Description

This PR checks the repository value to see whether it's a path or a URL. This would prevent conflicts with the version attribute since the expected action is to have the version attribute match the chart version if done locally.

Having a local chart will prevent the use of the version attribute so that no diff is shown.

Fixes #1157

Acceptance tests

• Have you added an acceptance test for the functionality being added?

 mau@mau-JKDT676NCP  ~/Dev/terraform-provider-helm   local-chart-verion ● ⍟2  make testacc TESTARGS="-run TestAccResourceRelease_LocalVersion"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./helm" -v -run TestAccResourceRelease_LocalVersion -timeout 10m
2023/07/27 09:55:23 Building chart repository...
2023/07/27 09:55:23 Created repository package for "broken-chart"
2023/07/27 09:55:23 Created repository package for "crds-chart"
2023/07/27 09:55:23 Created repository package for "dependency-bar"
2023/07/27 09:55:23 Created repository package for "dependency-foo"
2023/07/27 09:55:23 Created repository package for "failed-deploy"
2023/07/27 09:55:24 Created repository package for "kube-version"
2023/07/27 09:55:24 Created repository package for "test-chart"
2023/07/27 09:55:24 Created repository package for "test-chart-v2"
2023/07/27 09:55:24 Created repository package for "umbrella-chart"
2023/07/27 09:55:24 Built chart repository index
2023/07/27 09:55:24 Test repository is listening on http://localhost:55557
=== RUN   TestAccResourceRelease_LocalVersion
--- PASS: TestAccResourceRelease_LocalVersion (9.16s)
PASS
ok      github.com/hashicorp/terraform-provider-helm/helm       10.609s

 mau@mau-JKDT676NCP  ~/Dev/terraform-provider-helm   local-chart-verion ⍟3  make testacc TESTARGS="-run TestUseChartVersion"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./helm" -v -run TestUseChartVersion -timeout 10m
2023/08/03 11:54:11 Building chart repository...
2023/08/03 11:54:11 Created repository package for "broken-chart"
2023/08/03 11:54:11 Created repository package for "crds-chart"
2023/08/03 11:54:11 Created repository package for "dependency-bar"
2023/08/03 11:54:11 Created repository package for "dependency-foo"
2023/08/03 11:54:11 Created repository package for "failed-deploy"
2023/08/03 11:54:11 Created repository package for "kube-version"
2023/08/03 11:54:11 Created repository package for "test-chart"
2023/08/03 11:54:11 Created repository package for "test-chart-v2"
2023/08/03 11:54:11 Created repository package for "umbrella-chart"
2023/08/03 11:54:12 Built chart repository index
2023/08/03 11:54:12 Test repository is listening on http://localhost:56084
=== RUN   TestUseChartVersion
--- PASS: TestUseChartVersion (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-helm/helm     1.113s

Release Note

Release note for CHANGELOG:

`helm/resource_release.go`: Fix: version conflicts when using local chart 

References

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[tstraley]

Does this work for cases of soft version pinning (eg. ~1.47.0) in the helm_release?

[BBBmau]

Does this work for cases of soft version pinning (eg. ~1.47.0) in the helm_release?

Thank you for mentioning this case @tstraley, yes it will work with soft version pinning. It will still ignore whatever version attribute is set assuming you are not getting a chart from a repo.

[alexsomesan]

LGTM. Might need approval from @jrhouston because he had a "request changes" comment.