Ignore "release: not found" error on helm_resource destroy

Author: sbocinec

helm/resource_release.go

@@ -865,7 +865,7 @@ func resourceReleaseDelete(ctx context.Context, d *schema.ResourceData, meta int
 	uninstall.Timeout = time.Duration(d.Get("timeout").(int)) * time.Second
 
 	res, err := uninstall.Run(name)
-	if err != nil {
+	if err != nil && !errors.Is(err, driver.ErrReleaseNotFound) {
 		return diag.FromErr(err)
 	}
 

helm/resource_release_test.go

@@ -1758,6 +1758,45 @@ func TestAccResourceRelease_delete_regression(t *testing.T) {
 	})
 }
 
+func TestAccResourceRelease_destroy_ignoreNotFoundError(t *testing.T) {
+	name := randName("ignore-not-found-error")
+	namespace := createRandomNamespace(t)
+	defer deleteNamespace(t, namespace)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() { testAccPreCheck(t) },
+		ProviderFactories: map[string]func() (*schema.Provider, error){
+			"helm": func() (*schema.Provider, error) {
+				return Provider(), nil
+			},
+		},
+		Steps: []resource.TestStep{
+			{
+				Config: testAccHelmReleaseConfigBasic(testResourceName, namespace, name, "1.2.3"),
+				Check: resource.ComposeTestCheckFunc(
+					func(state *terraform.State) error {
+						cmd := exec.Command("helm", "--kubeconfig", os.Getenv("KUBE_CONFIG_PATH"), "uninstall", "--namespace", namespace, name)
+						out, err := cmd.CombinedOutput()
+						t.Log(string(out))
+						if err != nil {
+							t.Fatal(err)
+						}
+						return err
+					},
+					resource.TestCheckResourceAttr("helm_release.test", "metadata.0.namespace", namespace),
+					resource.TestCheckResourceAttr("helm_release.test", "metadata.0.version", "1.2.3"),
+					resource.TestCheckResourceAttr("helm_release.test", "status", release.StatusDeployed.String()),
+				),
+				ResourceName:       testResourceName,
+				PlanOnly:           false,
+				RefreshState:       false,
+				ExpectNonEmptyPlan: true,
+			},
+		},
+		CheckDestroy: testAccCheckHelmReleaseDestroy(namespace),
+	})
+}
+
 func getReleaseJSONManifest(namespace, name string) (string, error) {
 	cmd := exec.Command("helm", "--kubeconfig", os.Getenv("KUBE_CONFIG_PATH"), "get", "manifest", "--namespace", namespace, name)
 	manifest, err := cmd.Output()