add support for attribute level deprecation messages#346
Merged
Conversation
ansgarm
force-pushed
the
attribute-deprecation-messages
branch
2 times, most recently
from
e69c7cb to
7a034ca
Compare
1 task
ansgarm
force-pushed
the
attribute-deprecation-messages
branch
from
444317a to
10c0cfc
Compare
rainkwan
reviewed
Feb 17, 2026
| Description: "test description", | ||
| DescriptionKind: tfprotov6.StringKindPlain, | ||
| Version: 1, | ||
| Deprecated: true, |
Contributor
There was a problem hiding this comment.
Just a vague thought but what happens if deprecated is false but there is a deprecation message set anyway, the answer is nothing, right?
Member
Author
There was a problem hiding this comment.
Terraform will raise an error:
https://github.com/hashicorp/terraform/blob/c8a05ab45b30a36395339727f7c2f2d3059da604/internal/configs/configschema/internal_validate.go#L33
That said, in providers you can only set the deprecation message anyway and if it exists the Deprecated field will be set to true. So we don't need to do anything further in providers. And I don't think we validate these things on the protocol level usually 🤔
rainkwan
previously approved these changes
Feb 17, 2026
Contributor
rainkwan
left a comment
rainkwan
left a comment
There was a problem hiding this comment.
Changes all look to be logical 👍🏽 LGTM
3 tasks
ansgarm
force-pushed
the
attribute-deprecation-messages
branch
from
10c0cfc to
5b69f72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on hashicorp/terraform-plugin-go#600