Skip to content

Conversation

@mismithhisler
Copy link
Member

@mismithhisler mismithhisler commented Dec 1, 2025

Description

Jobs with more than one allocation are not being stopped correctly due to a bug where the results in different alloc sets were being overwritten. These changes update the reconciler stop logic to stop all allocations in the job.

Testing & Reproduction steps

Run a job with more than one task group, and then stop that job. All allocations should be stopped.

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@mismithhisler mismithhisler self-assigned this Dec 1, 2025
@mismithhisler mismithhisler requested review from a team as code owners December 1, 2025 11:12
pkazmierczak
pkazmierczak previously approved these changes Dec 1, 2025
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and a good catch, sorry to see this hasn't been caught by testing before...

@pkazmierczak
Copy link
Contributor

I think it'd be useful to backport this to 1.11 at least. Backporting to earlier versions would be great but there was a large refactor in 1.11 so that could mean having to write PRs for 1.10.x+ent and 1.8.x+ent from scratch.

@mismithhisler mismithhisler added the backport/1.11.x backport to 1.11.x release line label Dec 1, 2025
@mismithhisler
Copy link
Member Author

@pkazmierczak I looked at 1.10.x+ent and 1.8.x+ent and they are good to go

@mismithhisler mismithhisler merged commit ca873bc into main Dec 2, 2025
40 checks passed
@mismithhisler mismithhisler deleted the fix-reconciler-stopping-allocs branch December 2, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.11.x backport to 1.11.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants