Skip to content

Conversation

@mismithhisler
Copy link
Member

@mismithhisler mismithhisler commented Nov 25, 2025

Description

The email auth parameter was deprecated and is being removed in a future release of docker.

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

The email auth parameter was deprecated and is being removed in a future
release of docker.
@mismithhisler mismithhisler added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/1.11.x backport to 1.11.x release line labels Nov 25, 2025
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to err on the side of caution with these, but good golly, it was removed a looong time ago. I found this https://github.com/moby/moby/releases/tag/v1.11.0 (ctrl+f "email") dated 2016(!)

If you have any other links to reference, that would be welcome, but otherwise, LGTM!

@gulducat
Copy link
Member

Oh, do be sure to update the docs, too. I think this may be the only spot?

@mismithhisler mismithhisler merged commit dc2febe into main Nov 26, 2025
38 checks passed
@mismithhisler mismithhisler deleted the docker-driver-remove-deprecated-email branch November 26, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/1.11.x backport to 1.11.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants