landlock: check path exists on setup #27149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroberts
added
backport/ent/1.8.x+ent
chrisroberts
force-pushed
the
f-landlock-path-check
branch
from
197a075 to
0db1d9f
Compare
gulducat
previously approved these changes
Nov 24, 2025
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
lgtm!
just a pedantic nitpick on the code comment
Comment on lines
81
to
85
| // Add the initial directories, checking for existence | ||
| // prior to adding them. | ||
| for p, mode := range initialDirs { | ||
| _, err := os.Stat(p) | ||
| if err == nil { |
Member
There was a problem hiding this comment.
strictly speaking, it's not only checking existence. I suspect we do want to skip adding ones that produce an error of any kind (https://pkg.go.dev/os#pkg-variables) as you do here, but the comment is a tad misleading.
chrisroberts
force-pushed
the
f-landlock-path-check
branch
from
0db1d9f to
9c31a45
Compare
chrisroberts
force-pushed
the
f-landlock-path-check
branch
from
9c31a45 to
47ad7eb
Compare
When setting up landlock with the base set of directories, validate that each directory exists prior to including it within the landlock setup to prevent errors. If other errors are encountered when attempting to stat the path, ignore the path but log the error.
chrisroberts
force-pushed
the
f-landlock-path-check
branch
from
47ad7eb to
c69940e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting up landlock with the base set of directories, validate
that each directory exists prior to including it within the landlock
setup to prevent errors.
Testing & Reproduction steps
Links
Fixes #18721
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.