agent: obsolete ResolveToken in favor of Authenticate+ResolveACL
#27099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
added
theme/workload-identity
theme/acl
backport/ent/1.8.x+ent
tgross
reviewed
Nov 13, 2025
Member
tgross
left a comment
tgross
left a comment
There was a problem hiding this comment.
In addition to the comment I left, I think we end up wanting to implement this fix for other /v1/agent endpoints that are served without an RPC call.
pkazmierczak
changed the title
/agent/self endpoint should be WI-awareResolveToken in favor of Authenticate+ResolveACL
tgross
reviewed
Nov 14, 2025
tgross
approved these changes
Nov 14, 2025
pkazmierczak
added a commit
that referenced
this pull request
Nov 14, 2025
#27099) HTTP endpoints that use ResolveToken method to resolve ACL tokens cannot accept Workload Identity tokens, so in case a user wants to pass a JWT, they will get a UUID must be 36 characters error. This updates the code to call WI-aware Authenticate + ResolveACL instead.
pkazmierczak
added a commit
that referenced
this pull request
Nov 17, 2025
…+`ResolveACL` into release/1.11.x (#27103) * no-op commit due to failed cherry-picking * agent: obsolete `ResolveToken` in favor of `Authenticate`+`ResolveACL` (#27099) HTTP endpoints that use ResolveToken method to resolve ACL tokens cannot accept Workload Identity tokens, so in case a user wants to pass a JWT, they will get a UUID must be 36 characters error. This updates the code to call WI-aware Authenticate + ResolveACL instead. --------- Co-authored-by: temp <[email protected]> Co-authored-by: Piotr Kazmierczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP endpoints that use
ResolveTokenmethod to resolve ACL tokens cannotaccept Workload Identity tokens, so in case a user wants to pass a JWT, they
will get a
UUID must be 36 characterserror. This updates the code to callWI-aware
Authenticate+ResolveACLinstead.Resolves #27079