-
Notifications
You must be signed in to change notification settings - Fork 2k
Add autoscaling permissions to scale policy #27061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds the `read-job` and `submit-recommendation` permissions to the default `scale` policy. Both are needed for the nomad-autoscaler (enterprise) to run using the nomad targets. Additional APM and target permissions are still required.
aimeeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the docs!
gulducat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
recommending just a bit of wiggle on the changelog
c94c31f to
bed4693
Compare
gulducat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚖️
|
Note: in prep for migrating the docs to the web-unified-docs repo, the docs freeze starts on Friday, 11/14. Which release is this code going into? I need to figure out where the docs in this PR should go. |
|
@aimeeu this won't be going into 1.11.0 release, but will be in the next one (I think 1.11.1?) |
…1345) ## Description This moves the docs content from Allison Larson's merged PR hashicorp/nomad#27061 NMD-955 port from nomad/release-1.11.x to nomad/1.11.1 ## Links Jira: [NMD-955] ## Contributor checklists Review urgency: - [ ] ASAP: Bug fixes, broken content, imminent releases - [ ] 3 days: Small changes, easy reviews - [ ] 1 week: Default expectation - [x] Best effort: No urgency Pull request: - [x] Verify that the PR is set to merge into the correct base branch - [ ] Verify that all status checks passed - [ ] Verify that the preview environment deployed successfully - [ ] Add additional reviewers if they are not part of assigned groups Content: - [ ] I added redirects for any moved or removed pages - [ ] I followed the [Education style guide](https://github.com/hashicorp/web-unified-docs/tree/main/docs/style-guide) - [ ] I looked at the local or Vercel build to make sure the content rendered correctly ## Reviewer checklist - [ ] This PR is set to merge into the correct base branch. - [ ] The content does not contain technical inaccuracies. - [ ] The content follows the Education content and style guides. - [ ] I have verified and tested changes to instructions for end users. [NMD-955]: https://hashicorp.atlassian.net/browse/NMD-955?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Description
Adds the
read-jobandsubmit-recommendationpermissions to the defaultscalepolicy. Both are needed for the nomad-autoscaler (enterprise) to run using the nomad targets. Additional APM and target permissions are still required.Testing & Reproduction steps
Run the autoscaler with ACLs enabled, and using the scale policy.
Links
Internal ref: https://hashicorp.atlassian.net/browse/NMD-955
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.