-
Notifications
You must be signed in to change notification settings - Fork 2k
Update the error message for invalid variables #26235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a963383 to
d4d63b5
Compare
pkazmierczak
previously approved these changes
Jul 16, 2025
Contributor
pkazmierczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Member
Author
|
@aklkv Can you give me a hand over here? |
d4d63b5 to
e4de476
Compare
e4de476 to
866df37
Compare
Member
|
I've rebased this to pick up test fixes. |
tehut
approved these changes
Nov 21, 2025
6 tasks
tgross
pushed a commit
that referenced
this pull request
Nov 21, 2025
tgross
pushed a commit
that referenced
this pull request
Nov 21, 2025
Co-authored-by: Juana De La Cuesta <[email protected]>
olljanat
pushed a commit
to olljanat/nomad
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.8.x+ent
Changes are backported to 1.8.x+ent
backport/ent/1.10.x+ent
backport to 1.10.x+ent release line
backport/1.11.x
backport to 1.11.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the message returned when a storing a variable fails is:
Update it to be more inclusive, so it expresses that not only the name can be the error.
Fixes: #26234
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.