Skip to content

Conversation

@3nprob
Copy link
Contributor

@3nprob 3nprob commented May 19, 2025

Description

Allow configuring non-default identity for sidecar_task.

Testing & Reproduction steps

Sample job spec excerpt:

job "foo" {
  group "foo" {
    consul {}
    service {
      identity {
        aud = ["consul.io"]
      }
      connect {
        sidecar_service {}
        sidecar_task {
          identity {
            aud = ["consul.io"]
          }
        }
      }
    }
    task "foo" {
      # ...
    }
  }
}

Links

Fixes: #24660

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented May 19, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


3np seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@3nprob 3nprob force-pushed the sidecar_task-identity branch from f905250 to 60a3d9a Compare May 19, 2025 01:51
@3nprob 3nprob force-pushed the sidecar_task-identity branch from 60a3d9a to 06bf6fa Compare May 19, 2025 01:53
@3nprob 3nprob changed the title feat: allow configuring identities for sidecar_task feat(api/consul): allow configuring identities for sidecar_task May 19, 2025
@3nprob 3nprob marked this pull request as ready for review May 19, 2025 04:56
@3nprob 3nprob requested review from a team as code owners May 19, 2025 04:56
@3nprob
Copy link
Contributor Author

3nprob commented May 19, 2025

This has been manually tested. ✔️

@aimeeu aimeeu added the theme/docs Documentation issues and enhancements label May 19, 2025
aimeeu
aimeeu previously approved these changes May 19, 2025
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. Approving the docs content only.

@3nprob
Copy link
Contributor Author

3nprob commented May 19, 2025

Rebased on main and had to resolve merge-conflict in docs. No further changes.

aimeeu
aimeeu previously approved these changes May 20, 2025
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approval

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @3nprob and thanks for raising this PR.

Before I perform manual testing and thorough code review, would it be possible to add units tests for the new functionality covered? Once these are added I'll go ahead and review. Thanks.

@tgross tgross moved this from Triaging to In Progress in Nomad - Community Issues Triage Nov 7, 2025
@tgross
Copy link
Member

tgross commented Nov 7, 2025

(Internal ref https://hashicorp.atlassian.net/browse/NMD-439)

@aimeeu
Copy link
Contributor

aimeeu commented Nov 10, 2025

Note: The Nomad docs content is scheduled to move to web-unified-docs repo on Tuesday 18 Nov. If this PR does not merge before the move, I will take care of creating the docs PR in the new repo.

@tgross tgross added the backport/1.11.x backport to 1.11.x release line label Nov 11, 2025
@aimeeu
Copy link
Contributor

aimeeu commented Nov 19, 2025

Since the docs content has migrated to the web-unified-docs repo, the updates in this PR need to be recreated in the other repo. I can do the docs update, once Eng decides which release this is going into.

@tgross
Copy link
Member

tgross commented Nov 19, 2025

I can do the docs update, once Eng decides which release this is going into.

It's a minor new feature so it'd go into 1.11.x assuming this lands before next spring

@3nprob 3nprob force-pushed the sidecar_task-identity branch from 594695e to c06ee0e Compare November 27, 2025 23:05
@3nprob
Copy link
Contributor Author

3nprob commented Nov 27, 2025

Thanks for follow-up.

I've addressed the review feedback and rebased on main.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross dismissed jrasell’s stale review December 3, 2025 20:50

I've reviewed and this is addressed

@tgross tgross merged commit a8e8f02 into hashicorp:main Dec 3, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Nomad - Community Issues Triage Dec 3, 2025
@tgross
Copy link
Member

tgross commented Dec 3, 2025

I'll open a PR to migrate over the docs portion of this.

@tgross
Copy link
Member

tgross commented Dec 3, 2025

Docs PR: hashicorp/web-unified-docs#1448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.11.x backport to 1.11.x release line theme/consul/connect Consul Connect integration theme/docs Documentation issues and enhancements theme/workload-identity

Projects

Development

Successfully merging this pull request may close these issues.

Allow identity blocks in sidecar_task blocks

4 participants