-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(api/consul): allow configuring identities for sidecar_task #25877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 3np seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
f905250 to
60a3d9a
Compare
60a3d9a to
06bf6fa
Compare
|
This has been manually tested. ✔️ |
aimeeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs. Approving the docs content only.
e5457fd to
1b824d5
Compare
|
Rebased on |
aimeeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs approval
jrasell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @3nprob and thanks for raising this PR.
Before I perform manual testing and thorough code review, would it be possible to add units tests for the new functionality covered? Once these are added I'll go ahead and review. Thanks.
|
(Internal ref https://hashicorp.atlassian.net/browse/NMD-439) |
|
Note: The Nomad docs content is scheduled to move to web-unified-docs repo on Tuesday 18 Nov. If this PR does not merge before the move, I will take care of creating the docs PR in the new repo. |
|
Since the docs content has migrated to the web-unified-docs repo, the updates in this PR need to be recreated in the other repo. I can do the docs update, once Eng decides which release this is going into. |
It's a minor new feature so it'd go into 1.11.x assuming this lands before next spring |
TODO: Also cover VolumeMounts
Co-authored-by: Tim Gross <[email protected]>
Co-authored-by: Tim Gross <[email protected]>
594695e to
c06ee0e
Compare
|
Thanks for follow-up. I've addressed the review feedback and rebased on |
tgross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I'll open a PR to migrate over the docs portion of this. |
|
Docs PR: hashicorp/web-unified-docs#1448 |
Description
Allow configuring non-default
identityforsidecar_task.Testing & Reproduction steps
Sample job spec excerpt:
Links
Fixes: #24660
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.