Merge branch 'main' into compliance/update-headers

Author: DhariniJeeva

ui/admin/app/components/form/storage-bucket/index.hbs

@@ -3,17 +3,16 @@
   SPDX-License-Identifier: BUSL-1.1
 }}
 {{#if @model.type}}
-  {{component
-    (concat 'form/storage-bucket/' @model.compositeType)
-    model=@model
-    submit=@submit
-    cancel=@cancel
-    updateScope=this.updateScope
-    scopes=@scopes
-    pluginTypes=this.pluginTypes
-    changePluginType=@changePluginType
-    changeCredentialType=@changeCredentialType
-    rollbackSecretAttrs=this.rollbackSecretAttrs
-    toggleDisableCredentialRotation=this.toggleDisableCredentialRotation
-  }}
+  <this.storageBucketFormComponent
+    @model={{@model}}
+    @submit={{@submit}}
+    @cancel={{@cancel}}
+    @updateScope={{this.updateScope}}
+    @scopes={{@scopes}}
+    @pluginTypes={{this.pluginTypes}}
+    @changePluginType={{@changePluginType}}
+    @changeCredentialType={{@changeCredentialType}}
+    @rollbackSecretAttrs={{this.rollbackSecretAttrs}}
+    @toggleDisableCredentialRotation={{this.toggleDisableCredentialRotation}}
+  />
 {{/if}}

ui/admin/app/components/form/storage-bucket/index.js

@@ -7,11 +7,18 @@ import Component from '@glimmer/component';
 import { action } from '@ember/object';
 import { service } from '@ember/service';
 import { set } from '@ember/object';
-
+import { assert } from '@ember/debug';
 import {
   TYPE_CREDENTIAL_DYNAMIC,
   TYPES_STORAGE_BUCKET_PLUGIN,
 } from 'api/models/storage-bucket';
+import awsFormComponent from './aws';
+import minioFormComponent from './minio';
+
+const modelCompositeTypeToComponent = {
+  aws: awsFormComponent,
+  minio: minioFormComponent,
+};
 
 export default class FormStorageBucketComponent extends Component {
   // =attributes
@@ -24,6 +31,19 @@ export default class FormStorageBucketComponent extends Component {
     return TYPES_STORAGE_BUCKET_PLUGIN;
   }
 
+  /**
+   * returns the associated storage bucket form component for the model's composite type
+   */
+  get storageBucketFormComponent() {
+    const component =
+      modelCompositeTypeToComponent[this.args.model.compositeType];
+    assert(
+      `Mapped component must exist for storage bucket composite type: ${this.args.model.compositeType}`,
+      component,
+    );
+    return component;
+  }
+
   // =actions
   @action
   updateScope(event) {

ui/admin/app/components/form/target/index.hbs

@@ -4,12 +4,11 @@
 }}
 
 {{#if @model.type}}
-  {{component
-    (concat 'form/target/' @model.type)
-    model=@model
-    submit=@submit
-    cancel=@cancel
-    globalScope=@globalScope
-    changeType=@changeType
-  }}
+  <this.targetFormComponent
+    @model={{@model}}
+    @submit={{@submit}}
+    @cancel={{@cancel}}
+    @globalScope={{@globalScope}}
+    @changeType={{@changeType}}
+  />
 {{/if}}

ui/admin/app/components/form/target/index.js

@@ -0,0 +1,27 @@
+/**
+ * Copyright (c) HashiCorp, Inc.
+ * SPDX-License-Identifier: BUSL-1.1
+ */
+
+import Component from '@glimmer/component';
+import { assert } from '@ember/debug';
+import rdpTargetForm from './rdp';
+import sshTargetForm from './ssh';
+import tcpTargetForm from './tcp';
+
+const modelTypeToComponent = {
+  rdp: rdpTargetForm,
+  ssh: sshTargetForm,
+  tcp: tcpTargetForm,
+};
+
+export default class FormTargetIndex extends Component {
+  get targetFormComponent() {
+    const component = modelTypeToComponent[this.args.model.type];
+    assert(
+      `Mapped component must exist for target type: ${this.args.model.type}`,
+      component,
+    );
+    return component;
+  }
+}