Skip to content

Commit 7af3361

Browse files
hreineckemartinkpetersen
authored andcommitted
scsi_dh_alua: remove 'rel_port' from alua_dh_data structure
The 'relative port' field is not used, and might get stale when the port group changes. So remove the field altogether. Reviewed-by: Bart Van Assche <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Hannes Reinecke <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent aa90f49 commit 7af3361

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/scsi/device_handler/scsi_dh_alua.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ struct alua_port_group {
8787
struct alua_dh_data {
8888
struct alua_port_group *pg;
8989
int group_id;
90-
int rel_port;
9190
struct scsi_device *sdev;
9291
activate_complete callback_fn;
9392
void *callback_data;
@@ -325,12 +324,10 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h,
325324
return SCSI_DH_NOMEM;
326325
return SCSI_DH_DEV_UNSUPP;
327326
}
328-
h->rel_port = rel_port;
329-
330327
sdev_printk(KERN_INFO, sdev,
331328
"%s: device %s port group %x rel port %x\n",
332329
ALUA_DH_NAME, h->pg->device_id_str,
333-
h->group_id, h->rel_port);
330+
h->group_id, rel_port);
334331

335332
return alua_rtpg(sdev, h->pg);
336333
}
@@ -762,7 +759,6 @@ static int alua_bus_attach(struct scsi_device *sdev)
762759
if (!h)
763760
return -ENOMEM;
764761
h->pg = NULL;
765-
h->rel_port = -1;
766762
h->sdev = sdev;
767763

768764
err = alua_initialize(sdev, h);

0 commit comments

Comments
 (0)