Skip to content

Commit 3c8c21e

Browse files
peterhurleygregkh
authored andcommitted
staging/fwserial: Update TODO file per reviewer comments
Pursuant to this review https://lkml.org/lkml/2012/11/12/500 by Stefan Richter, update the TODO file. - Clarify purpose of TODO file - Remove firewire item #4. As discussed in this conversation https://lkml.org/lkml/2012/11/13/564 knowing the AR buffer size is not a hard requirement. The required rx buffer size can be determined experimentally. - Remove firewire item #5. This was a private note for further experimentation. - Change firewire item #1. Change suggested header from uapi header to kernel-only header. Signed-off-by: Peter Hurley <[email protected]> Acked-by: Stefan Richter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 0555cb9 commit 3c8c21e

File tree

1 file changed

+3
-8
lines changed
  • drivers/staging/fwserial

1 file changed

+3
-8
lines changed

drivers/staging/fwserial/TODO

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
TODOs
2-
-----
1+
TODOs prior to this driver moving out of staging
2+
------------------------------------------------
33
1. Implement retries for RCODE_BUSY, RCODE_NO_ACK and RCODE_SEND_ERROR
44
- I/O is handled asynchronously which presents some issues when error
55
conditions occur.
@@ -11,14 +11,9 @@ TODOs
1111
-- Issues with firewire stack --
1212
1. This driver uses the same unregistered vendor id that the firewire core does
1313
(0xd00d1e). Perhaps this could be exposed as a define in
14-
firewire-constants.h?
14+
firewire.h?
1515
3. Maybe device_max_receive() and link_speed_to_max_payload() should be
1616
taken up by the firewire core?
17-
4. To avoid dropping rx data while still limiting the maximum buffering,
18-
the size of the AR context must be known. How to expose this to drivers?
19-
5. Explore if bigger AR context will reduce RCODE_BUSY responses
20-
(or auto-grow to certain max size -- but this would require major surgery
21-
as the current AR is contiguously mapped)
2217

2318
-- Issues with TTY core --
2419
1. Hack for alternate device name scheme

0 commit comments

Comments
 (0)