vuln-fix: Temporary Directory Hijacking or Information Disclosure

This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure.

Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions
Severity: High
CVSSS: 7.3
Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory)

Reported-by: Jonathan Leitschuh <[email protected]>
Signed-off-by: Jonathan Leitschuh <[email protected]>

Bug-tracker: JLLeitschuh/security-research#10


Co-authored-by: Moderne <[email protected]>

Author: JLLeitschuh

hamcrest/src/test/java/org/hamcrest/io/FileMatchersTest.java

@@ -5,6 +5,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.file.Files;
 
 import static org.hamcrest.core.IsEqual.equalTo;
 
@@ -16,9 +17,9 @@ public class FileMatchersTest extends AbstractMatcherTest {
 
     @Override
     protected void setUp() throws IOException {
-        directory = File.createTempFile("myDir", "");
-        assertTrue("deleting " + directory, directory.delete());
-        assertTrue("mkdir " + directory, directory.mkdirs());
+        directory = Files.createTempDirectory("myDir").toFile();
+        assertTrue("deleting " + directory, true);
+        assertTrue("mkdir " + directory, true);
 
         file = new File(directory, "myFile");
         file.createNewFile();