Skip to content

Commit 6906854

Browse files
authored
updated favicon to svg only (#1694)
1 parent 6f6244b commit 6906854

File tree

5 files changed

+5
-3
lines changed

5 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ All notable changes to this project will be documented in this file. For commit
77
**Notes**:
88
- continue create user dir scope even if filesystem path creation fails #1509
99
- access control cache is cleared more aggresively to ensure no delay
10+
- removed default .ico favicon in favor of .svg
1011

1112
**BugFixes**:
1213
- indexing used size increases over time #1685
14+
- download progress is not shown #1687
1315

1416
## v1.1.2-beta
1517

backend/common/settings/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ func loadCustomFavicon() {
643643
allowedFormats := []string{".ico", ".png", ".svg"}
644644

645645
// Set default embedded favicon path
646-
Env.FaviconEmbeddedPath = "img/icons/favicon.ico"
646+
Env.FaviconEmbeddedPath = "img/icons/favicon.svg"
647647

648648
// Check if a custom favicon path is configured
649649
if Config.Frontend.Favicon == "" {

backend/http/httpRouter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ func StartHttp(ctx context.Context, storage *bolt.BoltStore, shutdownComplete ch
189189
publicRoutes.Handle("GET /static/", http.HandlerFunc(staticAssetHandler))
190190

191191
// Standard browser favicon and manifest routes
192-
router.HandleFunc("GET /favicon.ico", http.HandlerFunc(staticAssetHandler))
192+
router.HandleFunc("GET /favicon.svg", http.HandlerFunc(staticAssetHandler))
193193
router.HandleFunc("GET /site.webmanifest", http.HandlerFunc(staticAssetHandler))
194194
router.HandleFunc("GET /manifest.json", http.HandlerFunc(staticAssetHandler))
195195

backend/http/static.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ func staticAssetHandler(w http.ResponseWriter, r *http.Request) {
210210
// Handle special routes that need path mapping
211211
var assetPath string
212212
switch path {
213-
case "favicon.ico", "favicon":
213+
case "favicon.svg", "favicon":
214214
// Handle custom favicon from filesystem
215215
if settings.Env.FaviconIsCustom {
216216
http.ServeFile(w, r, settings.Env.FaviconPath)
-4.31 KB
Binary file not shown.

0 commit comments

Comments
 (0)