updated

Author: gtsteffaniak

CHANGELOG.md

@@ -9,6 +9,7 @@ All notable changes to this project will be documented in this file. For commit
  - oidc groups header updates admin permission of existing user (either add/remove if role exists)'
  - builds amd64 binary with musl for compatibility (glic error) https://github.com/gtsteffaniak/filebrowser/issues/755
  - renamed `server.sources.config.disabled` to `server.sources.config.disableIndexing`
+ - better support for running with disabled index.
  - small indexing behavior tweaks.
  - markdown viewer hides sidebar https://github.com/gtsteffaniak/filebrowser/issues/744
 
@@ -17,6 +18,8 @@ All notable changes to this project will be documented in this file. For commit
  - search result links not working with custom baseUrl https://github.com/gtsteffaniak/filebrowser/issues/746
  - preview error for office native preview https://github.com/gtsteffaniak/filebrowser/issues/744
  - more source name safety for special characters.
+ - shares with special character errors https://github.com/gtsteffaniak/filebrowser/issues/753
+ - backspace navigates back a page when typing https://github.com/gtsteffaniak/filebrowser/issues/663
 
 ## v0.7.8-beta
 

backend/http/raw.go

@@ -62,6 +62,11 @@ func addFile(path string, d *requestContext, tarWriter *tar.Writer, zipWriter *z
 	source := splitFile[0]
 	path = splitFile[1]
 	var err error
+	source, err = url.QueryUnescape(source)
+	if err != nil {
+		return fmt.Errorf("invalid source encoding: %v", err)
+	}
+	fmt.Println("source", source)
 	userScope := "/"
 	if d.user.Username != "publicUser" {
 		userScope, err = settings.GetScopeFromSourceName(d.user.Scopes, source)
@@ -188,8 +193,13 @@ func rawFilesHandler(w http.ResponseWriter, r *http.Request, d *requestContext,
 
 	firstFileSource := splitFile[0]
 	firstFilePath := splitFile[1]
-	fileName := filepath.Base(firstFilePath)
+	// decode url encoded source name
 	var err error
+	firstFileSource, err = url.QueryUnescape(firstFileSource)
+	if err != nil {
+		return http.StatusBadRequest, fmt.Errorf("invalid source encoding: %v", err)
+	}
+	fileName := filepath.Base(firstFilePath)
 	userscope := "/"
 	if d.user.Username != "publicUser" {
 		userscope, err = settings.GetScopeFromSourceName(d.user.Scopes, firstFileSource)
@@ -323,11 +333,15 @@ func computeArchiveSize(fileList []string, d *requestContext) (int64, error) {
 		}
 		source := splitFile[0]
 		path := splitFile[1]
+		var err error
+		source, err = url.QueryUnescape(source)
+		if err != nil {
+			return http.StatusBadRequest, fmt.Errorf("invalid source encoding: %v", err)
+		}
 		idx := indexing.GetIndex(source)
 		if idx == nil {
 			return 0, fmt.Errorf("source %s is not available", source)
 		}
-		var err error
 		userScope := "/"
 		if d.user.Username != "publicUser" {
 			userScope, err = settings.GetScopeFromSourceName(d.user.Scopes, source)
@@ -342,7 +356,10 @@ func computeArchiveSize(fileList []string, d *requestContext) (int64, error) {
 		indexPath := idx.MakeIndexPath(realPath)
 		info, ok := idx.GetReducedMetadata(indexPath, isDir)
 		if !ok {
-			return 0, fmt.Errorf("failed to get metadata info for %s", path)
+			info, err = idx.GetFsDirInfo(indexPath)
+			if err != nil {
+				return 0, fmt.Errorf("failed to get file info for %s : %v", path, err)
+			}
 		}
 		estimatedSize += info.Size
 	}

backend/http/share.go

@@ -69,13 +69,6 @@ func shareGetHandler(w http.ResponseWriter, r *http.Request, d *requestContext)
 	source := r.URL.Query().Get("source")
 	if source == "" {
 		source = settings.Config.Server.DefaultSource.Name
-	} else {
-		var err error
-		// decode url encoded source name
-		source, err = url.QueryUnescape(source)
-		if err != nil {
-			return http.StatusBadRequest, fmt.Errorf("invalid source encoding: %v", err)
-		}
 	}
 	// Decode the URL-encoded path
 	path, err := url.QueryUnescape(encodedPath)
@@ -199,13 +192,6 @@ func sharePostHandler(w http.ResponseWriter, r *http.Request, d *requestContext)
 	sourceName := r.URL.Query().Get("source")
 	if sourceName == "" {
 		sourceName = config.Server.DefaultSource.Name
-	} else {
-		var err error
-		// decode url encoded source name
-		sourceName, err = url.QueryUnescape(sourceName)
-		if err != nil {
-			return http.StatusBadRequest, fmt.Errorf("invalid source encoding: %v", err)
-		}
 	}
 	source := config.Server.NameToSource[sourceName]
 

frontend/src/api/share.js

@@ -10,7 +10,7 @@ export async function list() {
 
 export async function get(path, source) {
   try {
-    const params = { path, source };
+    const params = { path: encodeURIComponent(path), source: encodeURIComponent(source) };
     const apiPath = getApiPath("api/share",params);
     let data = fetchJSON(apiPath);
     return adjustedData(data, path);
@@ -29,7 +29,7 @@ export async function remove(hash) {
 }
 
 export async function create(path, source, password = "", expires = "", unit = "hours") {
-  const params = { path: encodeURIComponent(path), source: source };
+  const params = { path: encodeURIComponent(path), source: encodeURIComponent(source) };
   const apiPath = getApiPath("api/share",params);
   let body = "{}";
   if (password != "" || expires !== "" || unit !== "hours") {

frontend/src/views/files/ListingView.vue

@@ -608,6 +608,9 @@ export default {
           break;
 
         case "Backspace":
+          if (getters.CurrentPromptName !== null) {
+            return;
+          }
           // go back
           router.push({ path: newPath });
           break;