Skip to content

Commit ae93175

Browse files
committed
Re-enable 5.6 tests
Motivation: https://bugs.swift.org/browse/SR-15955 precluded tests from running on Swift 5.6. This has been resolved in Swift 5.6.1. Modifications: - Re-enable tests on 5.6 - Disable TSAN on 5.6 (the tests for AsyncServerHandler are abusing `EmbeddedChannel`; the tests will be rewritten when the handler state machine is rewritten and the AsyncEmbeddedChannel comes to fruition) Result: Tests run on 5.6
1 parent 305677e commit ae93175

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
matrix:
2626
include:
2727
- image: swift:5.6-focal
28-
swift-test-flags: "--enable-test-discovery --sanitize=thread"
28+
swift-test-flags: "--enable-test-discovery"
2929
- image: swift:5.5-focal
3030
swift-test-flags: "--enable-test-discovery"
3131
- image: swift:5.4-focal
@@ -46,8 +46,6 @@ jobs:
4646
run: swift build ${{ matrix.swift-build-flags }}
4747
timeout-minutes: 20
4848
- name: 🧪 Test
49-
# Skip tests on 5.6: https://bugs.swift.org/browse/SR-15955
50-
if: ${{ matrix.image != 'swift:5.6-focal' }}
5149
run: swift test ${{ matrix.swift-test-flags }}
5250
timeout-minutes: 20
5351
performance-tests:
@@ -127,8 +125,6 @@ jobs:
127125
GRPC_NO_NIO_SSL: 1
128126
timeout-minutes: 20
129127
- name: Test without NIOSSL
130-
# Skip tests on 5.6: https://bugs.swift.org/browse/SR-15955
131-
if: ${{ matrix.image != 'swift:5.6-focal' }}
132128
run: swift test --enable-test-discovery
133129
env:
134130
GRPC_NO_NIO_SSL: 1

0 commit comments

Comments
 (0)