Skip to content

Commit 0956c24

Browse files
authored
Merge pull request #1297 from murgatroid99/grpc-js_dont_test_ipv6_records
grpc-js: tests: skip checking for IPv6 addresses from DNS servers
2 parents c3fc579 + ca18cca commit 0956c24

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

packages/grpc-js/test/test-resolver.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,9 @@ describe('Name Resolver', () => {
214214
const resolver = resolverManager.createResolver(target, listener);
215215
resolver.updateResolution();
216216
});
217-
it('Should resolve a DNS name to an IPv6 address', done => {
217+
/* TODO(murgatroid99): re-enable this test, once we can get the IPv6 result
218+
* consistently */
219+
it.skip('Should resolve a DNS name to an IPv6 address', done => {
218220
const target = 'loopback6.unittest.grpc.io';
219221
const listener: resolverManager.ResolverListener = {
220222
onSuccessfulResolution: (
@@ -255,14 +257,8 @@ describe('Name Resolver', () => {
255257
addr.port === 443
256258
)
257259
);
258-
assert(
259-
addressList.some(
260-
addr =>
261-
isTcpSubchannelAddress(addr) &&
262-
addr.host === '::1' &&
263-
addr.port === 443
264-
)
265-
);
260+
/* TODO(murgatroid99): check for IPv6 result, once we can get that
261+
* consistently */
266262
done();
267263
},
268264
onError: (error: StatusObject) => {

0 commit comments

Comments
 (0)