Skip to content

Commit c5b160e

Browse files
balancer: enable GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES by default (#9017)
Part of #5288 Follow up of PR: #8837 This PR enabled the env variable GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES by default to transition balancer registries to be case-sensitive. RELEASE NOTES: * balancer: balancer registries are now case-sensitive by default. Disable GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES env var to temporarily revert this behavior.
1 parent 412cfbd commit c5b160e

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

balancer/balancer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func Register(b Builder) {
6060
if !envconfig.CaseSensitiveBalancerRegistries {
6161
name = strings.ToLower(name)
6262
if name != b.Name() {
63-
logger.Warningf("Balancer registered with name %q. grpc-go will be switching to case sensitive balancer registries soon. After 2 releases, we will enable the env var by default.", b.Name())
63+
logger.Warningf("Balancer registered with name %q. grpc-go has switched to case sensitive balancer registries. GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES env variable will be removed in release v1.82.0", b.Name())
6464
}
6565
}
6666
m[name] = b
@@ -85,7 +85,7 @@ func Get(name string) Builder {
8585
if !envconfig.CaseSensitiveBalancerRegistries {
8686
lowerName := strings.ToLower(name)
8787
if lowerName != name {
88-
logger.Warningf("Balancer retrieved for name %q. grpc-go will be switching to case sensitive balancer registries soon. After 2 releases, we will enable the env var by default.", name)
88+
logger.Warningf("Balancer retrieved for name %q. grpc-go has switched to case sensitive balancer registries. GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES env variable will be removed in release v1.82.0", name)
8989
}
9090
name = lowerName
9191
}

internal/envconfig/envconfig.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ var (
7878
EnableDefaultPortForProxyTarget = boolFromEnv("GRPC_EXPERIMENTAL_ENABLE_DEFAULT_PORT_FOR_PROXY_TARGET", true)
7979

8080
// CaseSensitiveBalancerRegistries is set if the balancer registry should be
81-
// case-sensitive. This is disabled by default, but can be enabled by setting
81+
// case-sensitive. This is enabled by default, but can be disabled by setting
8282
// the env variable "GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES"
83-
// to "true".
83+
// to "false".
8484
//
85-
// TODO: After 2 releases, we will enable the env var by default.
86-
CaseSensitiveBalancerRegistries = boolFromEnv("GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES", false)
85+
// This env varible will be removed in release v1.82.0.
86+
CaseSensitiveBalancerRegistries = boolFromEnv("GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES", true)
8787

8888
// XDSAuthorityRewrite indicates whether xDS authority rewriting is enabled.
8989
// This feature is defined in gRFC A81 and is enabled by setting the

0 commit comments

Comments
 (0)