client: log last error on subchannel connectivity change (#6109)

s-matyukevich · web-flow · commit a1e657ce53ba · 2023-03-15T10:19:01.000-07:00
diff --git a/clientconn.go b/clientconn.go
@@ -1113,7 +1113,11 @@ func (ac *addrConn) updateConnectivityState(s connectivity.State, lastErr error)
 		return
 	}
 	ac.state = s
-	channelz.Infof(logger, ac.channelzID, "Subchannel Connectivity change to %v", s)
+	if lastErr == nil {
+		channelz.Infof(logger, ac.channelzID, "Subchannel Connectivity change to %v", s)
+	} else {
+		channelz.Infof(logger, ac.channelzID, "Subchannel Connectivity change to %v, last error: %s", s, lastErr)
+	}
 	ac.cc.handleSubConnStateChange(ac.acbw, s, lastErr)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1113,7 +1113,11 @@ func (ac *addrConn) updateConnectivityState(s connectivity.State, lastErr error)`
`1113`	`1113`	`return`
`1114`	`1114`	`}`
`1115`	`1115`	`ac.state = s`
`1116`		`- channelz.Infof(logger, ac.channelzID, "Subchannel Connectivity change to %v", s)`
	`1116`	`+ if lastErr == nil {`
	`1117`	`+ channelz.Infof(logger, ac.channelzID, "Subchannel Connectivity change to %v", s)`
	`1118`	`+ } else {`
	`1119`	`+ channelz.Infof(logger, ac.channelzID, "Subchannel Connectivity change to %v, last error: %s", s, lastErr)`
	`1120`	`+ }`
`1117`	`1121`	`ac.cc.handleSubConnStateChange(ac.acbw, s, lastErr)`
`1118`	`1122`	`}`
`1119`	`1123`