balancer/weightedroundrobin: fix ticker leak on update (#6655)

ginayeh · web-flow · commit 67a53a6b8939 · 2023-09-21T15:56:23.000-07:00
Authored-by: Antoine Tollenaere &lt;atollena@gmail.com&gt;
diff --git a/balancer/weightedroundrobin/balancer.go b/balancer/weightedroundrobin/balancer.go
@@ -369,6 +369,7 @@ func (p *picker) start(ctx context.Context) {
 	}
 	go func() {
 		ticker := time.NewTicker(time.Duration(p.cfg.WeightUpdatePeriod))
+		defer ticker.Stop()
 		for {
 			select {
 			case <-ctx.Done():

Original file line number	Diff line number	Diff line change
`@@ -369,6 +369,7 @@ func (p *picker) start(ctx context.Context) {`
`369`	`369`	`}`
`370`	`370`	`go func() {`
`371`	`371`	`ticker := time.NewTicker(time.Duration(p.cfg.WeightUpdatePeriod))`
	`372`	`+ defer ticker.Stop()`
`372`	`373`	`for {`
`373`	`374`	`select {`
`374`	`375`	`case <-ctx.Done():`