xdsclient/csds: fix leaked metadata (#5339)

menghanl · dfawley · commit 10b610c0beaf · 2022-05-13T16:13:42.000-07:00
diff --git a/xds/internal/xdsclient/pubsub/update.go b/xds/internal/xdsclient/pubsub/update.go
@@ -232,7 +232,7 @@ func (pb *Pubsub) NewClusters(updates map[string]xdsresource.ClusterUpdateErrTup
 			// from cache, and also send an resource not found error to indicate
 			// resource removed.
 			delete(pb.cdsCache, name)
-			pb.ldsMD[name] = xdsresource.UpdateMetadata{Status: xdsresource.ServiceStatusNotExist}
+			pb.cdsMD[name] = xdsresource.UpdateMetadata{Status: xdsresource.ServiceStatusNotExist}
 			for wi := range pb.cdsWatchers[name] {
 				wi.resourceNotFound()
 			}

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ func (pb *Pubsub) NewClusters(updates map[string]xdsresource.ClusterUpdateErrTup`
`232`	`232`	`// from cache, and also send an resource not found error to indicate`
`233`	`233`	`// resource removed.`
`234`	`234`	`delete(pb.cdsCache, name)`
`235`		`- pb.ldsMD[name] = xdsresource.UpdateMetadata{Status: xdsresource.ServiceStatusNotExist}`
	`235`	`+ pb.cdsMD[name] = xdsresource.UpdateMetadata{Status: xdsresource.ServiceStatusNotExist}`
`236`	`236`	`for wi := range pb.cdsWatchers[name] {`
`237`	`237`	`wi.resourceNotFound()`
`238`	`238`	`}`