Skip to content

Commit 5dd36b1

Browse files
committed
Fix pluralization of "seconds" in test output
1 parent d115c02 commit 5dd36b1

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ only add here if you are working on a PR
99
### Added
1010

1111
### Fixed
12+
- Fixed grammar in duration message to use singular "second" when appropriate (e.g., "Took 1 second" instead of "Took 1 seconds")
1213

1314
## 5.5.0 - 2025-10-30
1415

lib/parallel_tests/cli.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ def execute_command_in_parallel(command, num_processes, options)
436436

437437
def report_time_taken(&block)
438438
seconds = ParallelTests.delta(&block).to_i
439-
puts "\nTook #{seconds} seconds#{detailed_duration(seconds)}"
439+
puts "\nTook #{pluralize(seconds, 'second')}#{detailed_duration(seconds)}"
440440
end
441441

442442
def detailed_duration(seconds)

spec/integration_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def self.it_runs_the_default_folder_if_it_exists(type, test_folder)
112112
expect(result).to include_exactly_times('1 example, 0 failure', 2) # 2 results
113113
expect(result).to include_exactly_times('2 examples, 0 failures', 1) # 1 summary
114114
expect(result).to include_exactly_times(/Finished in \d+(\.\d+)? seconds/, 2)
115-
expect(result).to include_exactly_times(/Took \d+ seconds/, 1) # parallel summary
115+
expect(result).to include_exactly_times(/Took \d+ seconds?/, 1) # parallel summary
116116

117117
# verify empty groups are discarded. if retained then it'd say 4 processes for 2 specs
118118
expect(result).to include '2 processes for 2 specs, ~ 1 spec per process'

0 commit comments

Comments
 (0)