Skip to content

Commit 775feeb

Browse files
committed
add missing full_name to test cask objects
Followup to Homebrew#21417. This removes the needs for `respond_to?` gymnastics.
1 parent 98c10f6 commit 775feeb

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Library/Homebrew/bundle/cask_dumper.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,9 @@ def self.cask_is_outdated_using_greedy?(cask_name)
3737
sig { params(describe: T::Boolean).returns(String) }
3838
def self.dump(describe: false)
3939
casks.map do |cask|
40-
name = cask.respond_to?(:full_name) ? cask.full_name : cask.to_s
4140
description = "# #{cask.desc}\n" if describe && cask.desc.present?
4241
config = ", args: { #{explicit_s(cask.config)} }" if cask.config.present? && cask.config.explicit.present?
43-
"#{description}cask \"#{name}\"#{config}"
42+
"#{description}cask \"#{cask.full_name}\"#{config}"
4443
end.join("\n")
4544
end
4645

Library/Homebrew/test/bundle/cask_dumper_spec.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,14 @@
4343
end
4444

4545
context "when casks `foo`, `bar` and `baz` are installed, with `baz` being a formula requirement" do
46-
let(:foo) { instance_double(Cask::Cask, to_s: "foo", desc: nil, config: nil) }
47-
let(:baz) { instance_double(Cask::Cask, to_s: "baz", desc: "Software", config: nil) }
46+
let(:foo) { instance_double(Cask::Cask, to_s: "foo", full_name: "foo", desc: nil, config: nil) }
47+
let(:baz) { instance_double(Cask::Cask, to_s: "baz", full_name: "baz", desc: "Software", config: nil) }
4848
let(:bar) do
4949
instance_double(
50-
Cask::Cask, to_s: "bar",
51-
desc: nil,
52-
config: instance_double(
50+
Cask::Cask, to_s: "bar",
51+
full_name: "bar",
52+
desc: nil,
53+
config: instance_double(
5354
Cask::Config,
5455
explicit: {
5556
fontdir: "/Library/Fonts",

0 commit comments

Comments
 (0)