fix: 🐛 fixed duplicate react-native-svg duplicate import#894
Merged
gregberge merged 1 commit intogregberge:mainfrom Aug 15, 2023
MohammadKurjieh:fix-duplicate-react-native-svg-import
Merged
fix: 🐛 fixed duplicate react-native-svg duplicate import#894gregberge merged 1 commit intogregberge:mainfrom MohammadKurjieh:fix-duplicate-react-native-svg-import
gregberge merged 1 commit intogregberge:mainfrom
MohammadKurjieh:fix-duplicate-react-native-svg-import
Conversation
When updating the imports of react-native-svg there is no check on the importKind. This would cause a wrong update import and a crash in the cli.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
==========================================
+ Coverage 92.87% 92.89% +0.01%
==========================================
Files 32 32
Lines 758 760 +2
Branches 253 251 -2
==========================================
+ Hits 704 706 +2
Misses 53 53
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@gregberge are you able to take a look at this PR? 🙏 |
Owner
Yes but I didn't have time to release and merge it. Will do soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolved #891
Summary
When updating the imports of react-native-svg there is no check on the importKind. This would cause a wrong update import and a crash in the cli. This bug occurs when combining expandProp, native and typescript in the config.
Current Output
Fixed Output
Test plan
Run the cli with expandProp, native and typescript in the config. It used to crash and complain about duplicate imports.
Acknowledgement
Thanks to @atomicpages for their investigative work, it helped me track the bug.