Skip to content

Commit 7287ffa

Browse files
enisdenjogithub-actions[bot]theguild-bot
authored
Try out whatwg-node fetch using native Readable's listeners directly (#1338)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: theguild-bot <[email protected]>
1 parent ffa3753 commit 7287ffa

File tree

17 files changed

+57
-44
lines changed

17 files changed

+57
-44
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@graphql-mesh/transport-http-callback': patch
3+
---
4+
5+
dependencies updates:
6+
7+
- Updated dependency [`@whatwg-node/fetch@^0.10.9` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/0.10.9) (from `^0.10.8`, in `dependencies`)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@graphql-tools/executor-http': patch
3+
---
4+
5+
dependencies updates:
6+
7+
- Updated dependency [`@whatwg-node/fetch@^0.10.9` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/0.10.9) (from `^0.10.8`, in `dependencies`)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@graphql-tools/federation': patch
3+
---
4+
5+
dependencies updates:
6+
7+
- Updated dependency [`@whatwg-node/fetch@^0.10.9` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/0.10.9) (from `^0.10.8`, in `dependencies`)

e2e/federation-subscriptions-passthrough/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"private": true,
44
"dependencies": {
55
"@graphql-mesh/transport-ws": "workspace:^",
6-
"@whatwg-node/fetch": "^0.10.8",
6+
"@whatwg-node/fetch": "^0.10.9",
77
"graphql": "^16.9.0",
88
"tslib": "^2.8.1"
99
},
Binary file not shown.

examples/federation-subscriptions-passthrough/package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/federation-subscriptions-passthrough/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"private": true,
44
"dependencies": {
55
"@graphql-mesh/transport-ws": "^1.0.10",
6-
"@whatwg-node/fetch": "^0.10.8",
6+
"@whatwg-node/fetch": "^0.10.9",
77
"graphql": "^16.9.0",
88
"tslib": "^2.8.1",
99
"@apollo/server": "^4.12.2",

internal/e2e/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"@types/dockerode": "^3.3.42",
88
"@types/node": "^22.15.30",
99
"@whatwg-node/disposablestack": "^0.0.6",
10-
"@whatwg-node/fetch": "^0.10.8",
10+
"@whatwg-node/fetch": "^0.10.9",
1111
"dockerode": "^4.0.7",
1212
"glob": "^11.0.3",
1313
"graphql": "^16.9.0",

internal/perf/src/memtest.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -232,14 +232,6 @@ export function memtest(opts: MemtestOptions, setup: () => Promise<Server>) {
232232
frame.callstack.some(
233233
(stack) => stack.name === 'handleMaybePromise',
234234
)
235-
) &&
236-
!(
237-
// allocates a lot but all is freed confirmed through heap snapshot
238-
frame.callstack.some(
239-
(frame) =>
240-
frame.file?.includes('@whatwg-node/node-fetch') &&
241-
frame.name.includes('wrapIncomingMessageWithPassthrough'),
242-
)
243235
),
244236
)
245237
.filter((frame) => {

internal/testing/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"@graphql-tools/utils": "^10.7.2",
1717
"@types/node": "^22.15.30",
1818
"@whatwg-node/disposablestack": "^0.0.6",
19-
"@whatwg-node/fetch": "^0.10.8",
19+
"@whatwg-node/fetch": "^0.10.9",
2020
"@whatwg-node/promise-helpers": "^1.2.5",
2121
"graphql": "^16.10.0",
2222
"jest-leak-detector": "30.0.2",

0 commit comments

Comments
 (0)