fix: Clicks are not recorded on inputs with type button, submit or reset (#863)

Author: allansson

extension/src/frontend/index.ts

@@ -9,6 +9,7 @@ import {
   isNativeButton,
   isNativeCheckbox,
   isNativeRadio,
+  isNonButtonInput,
 } from '../utils/dom'
 
 import { WindowEventManager } from './manager'
@@ -62,7 +63,7 @@ manager.capture('click', (ev, manager) => {
   // We don't want to capture clicks on form elements since they will be
   // interacted with using e.g. the `selectOption` or `type` functions.
   if (
-    clickTarget instanceof HTMLInputElement ||
+    isNonButtonInput(clickTarget) ||
     clickTarget instanceof HTMLTextAreaElement ||
     clickTarget instanceof HTMLSelectElement ||
     clickTarget instanceof HTMLOptionElement

extension/src/utils/dom.ts

@@ -131,5 +131,21 @@ export function isNativeButton(element: Element) {
     return false
   }
 
-  return element.type === 'button' || element.type === 'submit'
+  return (
+    element.type === 'button' ||
+    element.type === 'submit' ||
+    element.type === 'reset'
+  )
+}
+
+export function isNonButtonInput(element: Element) {
+  if (element instanceof HTMLInputElement === false) {
+    return false
+  }
+
+  return (
+    element.type !== 'button' &&
+    element.type !== 'submit' &&
+    element.type !== 'reset'
+  )
 }

vite.extension.config.mts

@@ -20,6 +20,7 @@ export default defineConfig((env) => {
   ]
 
   const build: BuildOptions = {
+    minify: false,
     outDir: `.vite/build/extension`,
     sourcemap: 'inline',
   }