fix: error when legacy config exists

Author: jmattheis

config/config_test.go

@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/gotify/server/v2/mode"
+	"github.com/rs/zerolog"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -74,6 +75,26 @@ func TestGotifyConfigFile(t *testing.T) {
 	assert.Equal(t, "fromfile", conf.DefaultUser.Name)
 }
 
+func TestLegacyConfigFile(t *testing.T) {
+	mode.Set(mode.TestDev)
+	dir := t.TempDir()
+	assert.Nil(t, os.WriteFile(filepath.Join(dir, "config.yml"), []byte("server:\n  port: 1234\n"), 0o600))
+	t.Chdir(dir)
+
+	_, logs := Get()
+
+	fatals := []string{}
+	for _, log := range logs {
+		if log.Level == zerolog.FatalLevel {
+			fatals = append(fatals, log.Msg)
+		}
+	}
+	assert.Len(t, fatals, 1)
+	assert.Contains(t, fatals[0], "config.yml")
+	assert.Contains(t, fatals[0], "migrate-config")
+	assert.Contains(t, fatals[0], "https://gotify.net/docs/migrate-to-3")
+}
+
 func TestAddSlash(t *testing.T) {
 	mode.Set(mode.TestDev)
 	os.Setenv("GOTIFY_UPLOADEDIMAGESDIR", "../data/images")

config/file.go

@@ -11,7 +11,21 @@ import (
 
 var osStat = os.Stat
 
+func checkLegacyConfigFiles() []FutureLog {
+	var logs []FutureLog
+	for _, file := range []string{"config.yml", "/etc/gotify/config.yml"} {
+		if _, err := osStat(file); err == nil {
+			logs = append(logs, futureFatal(fmt.Sprintf("found %s, the YAML config file is no longer supported. Convert it with 'gotify-server migrate-config %s', see https://gotify.net/docs/migrate-to-3", file, file)))
+		}
+	}
+	return logs
+}
+
 func loadFiles() []FutureLog {
+	if logs := checkLegacyConfigFiles(); len(logs) > 0 {
+		return logs
+	}
+
 	if configFile := os.Getenv("GOTIFY_CONFIG_FILE"); configFile != "" {
 		log, _ := loadFile(configFile)
 		return []FutureLog{log}