address review comments

Author: eternal-flame-AD

auth/authentication.go

@@ -155,7 +155,7 @@ func (a *Auth) handleClient(checks ...func(*model.Client) (authState, error)) fu
 		if strings.HasPrefix(token, enhancedTokenPrefix) {
 			complexToken, err := ParseEnhancedToken(token)
 			if err != nil || !complexToken.ValidateTimestamp(timeNow().Unix()) {
-				return authStateSkip, err
+				return authStateSkip, nil
 			}
 			token = complexToken.PublicForm()
 		}
@@ -197,7 +197,7 @@ func (a *Auth) handleApplication(ctx *gin.Context) (authState, error) {
 	if strings.HasPrefix(token, enhancedTokenPrefix) {
 		complexToken, err := ParseEnhancedToken(token)
 		if err != nil || !complexToken.ValidateTimestamp(timeNow().Unix()) {
-			return authStateSkip, err
+			return authStateSkip, nil
 		}
 		token = complexToken.PublicForm()
 	}

auth/token_test.go

@@ -3,7 +3,6 @@ package auth
 import (
 	"crypto/rand"
 	"errors"
-	"log"
 	"testing"
 	"testing/iotest"
 
@@ -12,7 +11,6 @@ import (
 
 func TestNewComplexToken(t *testing.T) {
 	token := NewEnhancedToken("A12")
-	log.Printf("token: %s", token.String())
 	canonicalizedExpected := token.PublicForm()
 	tokenParsed, err := ParseEnhancedToken(token.String())
 	assert.NoError(t, err)

router/router_test.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"log"
 	"net/http"
 	"net/http/httptest"
 	"strings"
@@ -322,7 +321,6 @@ func (s *IntegrationSuite) TestSendMessage() {
 	token := &model.Application{}
 	json.NewDecoder(res.Body).Decode(token)
 	assert.Equal(s.T(), "backup-server", token.Name)
-	log.Printf("token: %s", token.Token)
 
 	req = s.newRequest("POST", "message", `{"message": "backup done", "title": "backup done"}`)
 	req.Header.Add("X-Gotify-Key", token.Token)

ui/src/application/AddApplicationDialog.tsx

@@ -10,6 +10,7 @@ import {NumberField} from '../common/NumberField';
 import React, {useState} from 'react';
 import {Typography} from '@mui/material';
 import {copyToClipboard} from '../clipboard';
+import {useStores} from '../stores';
 
 interface IProps {
     fClose: VoidFunction;
@@ -21,6 +22,7 @@ export const AddApplicationDialog = ({fClose, fOnSubmit}: IProps) => {
     const [name, setName] = useState('');
     const [description, setDescription] = useState('');
     const [defaultPriority, setDefaultPriority] = useState(0);
+    const {snackManager} = useStores();
 
     const submitEnabled = name.length !== 0;
     const submitAndNext = async () => {
@@ -86,7 +88,15 @@ export const AddApplicationDialog = ({fClose, fOnSubmit}: IProps) => {
             </DialogContent>
             <DialogActions>
                 {returnToken ? (
-                    <Button onClick={() => copyToClipboard(returnToken)}>Copy to clipboard</Button>
+                    <Button
+                        onClick={() =>
+                            copyToClipboard(returnToken).then(
+                                () => snackManager.snack('Copied to clipboard'),
+                                () => snackManager.snack('Cannot access clipboard.')
+                            )
+                        }>
+                        Copy to clipboard
+                    </Button>
                 ) : (
                     <Button onClick={fClose}>Cancel</Button>
                 )}

ui/src/client/AddClientDialog.tsx

@@ -9,6 +9,7 @@ import Tooltip from '@mui/material/Tooltip';
 import {NumberField} from '../common/NumberField';
 import {DialogContentText, Typography} from '@mui/material';
 import {copyToClipboard} from '../clipboard';
+import {useStores} from '../stores';
 
 interface IProps {
     fClose: VoidFunction;
@@ -19,7 +20,7 @@ const AddClientDialog = ({fClose, fOnSubmit}: IProps) => {
     const [returnToken, setReturnToken] = useState('');
     const [name, setName] = useState('');
     const [expiresAfter, setExpiresAfter] = useState(0);
-
+    const {snackManager} = useStores();
     const submitEnabled = name.length !== 0;
     const submitAndNext = async () => {
         const token = await fOnSubmit(name, Math.max(0, expiresAfter));
@@ -72,7 +73,15 @@ const AddClientDialog = ({fClose, fOnSubmit}: IProps) => {
             </DialogContent>
             <DialogActions>
                 {returnToken ? (
-                    <Button onClick={() => copyToClipboard(returnToken)}>Copy to clipboard</Button>
+                    <Button
+                        onClick={() =>
+                            copyToClipboard(returnToken).then(
+                                () => snackManager.snack('Copied to clipboard'),
+                                () => snackManager.snack('Cannot access clipboard.')
+                            )
+                        }>
+                        Copy to clipboard
+                    </Button>
                 ) : (
                     <Button onClick={fClose}>Cancel</Button>
                 )}

ui/src/clipboard.ts

@@ -2,16 +2,12 @@ export const copyToClipboard = async (value: string) => {
     try {
         await navigator.clipboard.writeText(value);
     } catch (error) {
-        console.error('Failed to copy to clipboard:', error);
-        try {
-            const elem = document.createElement('textarea');
-            elem.value = value;
-            document.body.appendChild(elem);
-            elem.select();
-            document.execCommand('copy');
-            document.body.removeChild(elem);
-        } catch (error) {
-            console.error('Failed to copy to clipboard (fallback):', error);
-        }
+        console.warn('Failed to copy to clipboard using Clipboard API:', error);
+        const elem = document.createElement('textarea');
+        elem.value = value;
+        document.body.appendChild(elem);
+        elem.select();
+        document.execCommand('copy');
+        document.body.removeChild(elem);
     }
 };

ui/src/common/CopyableSecret.tsx

@@ -21,7 +21,10 @@ const CopyableSecret = ({value, style}: IProps) => {
         <div style={style}>
             <IconButton
                 onClick={() =>
-                    copyToClipboard(value).finally(() => snackManager.snack('Copied to clipboard'))
+                    copyToClipboard(value).then(
+                        () => snackManager.snack('Copied to clipboard'),
+                        () => snackManager.snack('Cannot access clipboard.')
+                    )
                 }
                 title="Copy to clipboard"
                 size="large">

ui/src/tests/setup.ts

@@ -73,7 +73,6 @@ export const newTest = async (
     const browser = await puppeteer.launch({
         headless: process.env.CI === 'true',
         args: [`--window-size=1920,1080`, '--no-sandbox'],
-        executablePath: '/usr/bin/chromium',
     });
     const page = await browser.newPage();
     await page.setViewport({width: 1920, height: 1080});