Skip to content

Commit d611435

Browse files
committed
Assert intentUrl is never null in dialog
1 parent 0c3a17c commit d611435

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

app/src/main/kotlin/com/github/gotify/messages/IntentUrlDialogActivity.kt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,8 @@ internal class IntentUrlDialogActivity : AppCompatActivity() {
1414
setFinishOnTouchOutside(false)
1515
val binding = ActivityDialogIntentUrlBinding.inflate(layoutInflater)
1616
val intentUrl = intent.getStringExtra(EXTRA_KEY_URL)
17-
binding.cancelButton.setOnClickListener { finish() }
17+
assert(intentUrl != null) { "intentUrl may not be empty" }
1818

19-
if (intentUrl == null) {
20-
binding.urlView.text = getString(R.string.action_dialog_missing)
21-
binding.openButton.visibility = View.GONE
22-
setContentView(binding.root)
23-
return
24-
}
2519
binding.urlView.text = intentUrl
2620
binding.openButton.setOnClickListener {
2721
finish()
@@ -31,6 +25,7 @@ internal class IntentUrlDialogActivity : AppCompatActivity() {
3125
startActivity(this)
3226
}
3327
}
28+
binding.cancelButton.setOnClickListener { finish() }
3429
setContentView(binding.root)
3530
}
3631

0 commit comments

Comments
 (0)