Skip to content

fix: Changed name of methods Blob.from_string() and Bucket.from_string() to from_uri() #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: Changed name of methods Blob.from_string() and Bucket.from_string() to from_uri() #1335

merged 1 commit into from
Oct 7, 2024

Conversation

holtskinner
Copy link
Member

@holtskinner holtskinner commented Aug 6, 2024 •
edited
Loading

  • Other methods use "string" to refer to the actual content of the Blob, not the uri. The updated method name is more intuitive for developers.
  • Marked from_string() as deprecated and mapped functionality to from_uri().

Original reasoning for from_string() naming in #7693

@holtskinner holtskinner requested review from a team as code owners August 6, 2024 14:48
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 6, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Aug 6, 2024
@holtskinner holtskinner added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@holtskinner holtskinner changed the base branch from main to 3.0-devel October 4, 2024 17:19
@holtskinner holtskinner requested a review from a team as a code owner October 4, 2024 17:19
@holtskinner holtskinner requested review from glasnt and removed request for a team October 4, 2024 17:19
@holtskinner holtskinner changed the base branch from 3.0-devel to main October 4, 2024 17:20
@holtskinner holtskinner changed the base branch from main to 3.0-devel October 4, 2024 17:26
@holtskinner holtskinner closed this Oct 4, 2024
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: m Pull request size is medium. labels Oct 4, 2024
@holtskinner holtskinner reopened this Oct 4, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: u Pull request is empty. labels Oct 4, 2024
@holtskinner holtskinner requested a review from andrewsg October 4, 2024 17:39
@holtskinner holtskinner added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@andrewsg
Copy link
Contributor

andrewsg commented Oct 7, 2024

Thank you!

@andrewsg andrewsg merged commit ae917ee into 3.0-devel Oct 7, 2024
7 checks passed
@andrewsg andrewsg deleted the from_uri branch October 7, 2024 15:47
andrewsg pushed a commit that referenced this pull request Dec 5, 2024
@holtskinner @andrewsg
fix: Changed name of methods Blob.from_string() and `Bucket.from_st…
1b98fb2 
…ring()` to `from_uri()` (#1335)
andrewsg pushed a commit that referenced this pull request Dec 10, 2024
@holtskinner @andrewsg
fix: Changed name of methods Blob.from_string() and `Bucket.from_st…
a55f25d 
…ring()` to `from_uri()` (#1335)
andrewsg pushed a commit that referenced this pull request Dec 11, 2024
@holtskinner @andrewsg
fix: Changed name of methods Blob.from_string() and `Bucket.from_st…
58c1d03 
…ring()` to `from_uri()` (#1335)
@release-please release-please bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@glasnt glasnt Awaiting requested review from glasnt glasnt was automatically assigned from googleapis/python-samples-reviewers

Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API. kokoro:run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holtskinner @andrewsg @yoshi-kokoro