docs: changed broken logo #1866
Merged
+33
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuoweil
requested review from
tswast,
GarrettWu,
shobsi,
sycai,
jiaxunwu,
chelsea-lin and
jialuoo
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: m
shuoweil
force-pushed
the
shuowei-add-logo
branch
from
caa7a7c to
31215fa
Compare
tswast
reviewed
Jun 27, 2025
| @@ -35,12 +35,12 @@ | |||
| "\n", | |||
| " <td>\n", | |||
| " <a href=\"https://colab.research.google.com/github/googleapis/python-bigquery-dataframes/blob/main/notebooks/experimental/ai_operators.ipynb\">\n", | |||
| " <img src=\"https://cloud.google.com/ml-engine/images/colab-logo-32px.png\" alt=\"Colab logo\"> Run in Colab\n", | |||
| " <img src=\"../../third_party/logo/colab-logo.png\" alt=\"Colab logo\"> Run in Colab\n", | |||
There was a problem hiding this comment.
This will only render well on GitHub, not other places the notebook might be included. Please update this to
sycai
reviewed
Jun 27, 2025
| @@ -35,12 +35,12 @@ | |||
| "\n", | |||
| " <td>\n", | |||
| " <a href=\"https://colab.research.google.com/github/googleapis/python-bigquery-dataframes/blob/main/notebooks/experimental/ai_operators.ipynb\">\n", | |||
| " <img src=\"https://cloud.google.com/ml-engine/images/colab-logo-32px.png\" alt=\"Colab logo\"> Run in Colab\n", | |||
| " <img src=\"../../third_party/logo/colab-logo.png\" alt=\"Colab logo\"> Run in Colab\n", | |||
There was a problem hiding this comment.
Maybe you can upload the png files in another PR first, then use absolute paths instead?
shuoweil
force-pushed
the
shuowei-add-logo
branch
from
31215fa to
a12d42c
Compare
sycai
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: changed broken logo
b/427981044