fix(logging): Specifying resourceNames should fetch logs only from those resources #1597
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `getEntries` is called with a `resourceNames` array that specifies a logging bucket (particularly one in a
different project), the library was incorrectly appending the current project's ID to the array.
This resulted in an invalid request, causing the Logging API to reject it with an `INVALID_ARGUMENT` error.
The fix adjusts the logic to only inject the default project ID if the `resourceNames` array is explicitly empty. This
preserves the expected default behavior of searching within the current project, while respecting user-provided
resource names for cross-project queries.
Fixes: #1593
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: s
cindy-peng
force-pushed
the
bhshkh-fix/resource-name-other-projects
branch
from
dfb2668 to
b62611c
Compare
product-auto-label
bot
added
size: s
danieljbruce
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork PR of the fix for resourceNames: #1596
We have modified yaml file to bypass node 18 check (Which was introduced in node 14 upgrade: c294f5d, not sure why 18 was introduced as a required test environment since we have not started node 18 upgrade). The doc check was also irrelevant and caused by 429 too many requests.
We will revert the testing environment configuration once the fix is rolled out.