-
Notifications
You must be signed in to change notification settings - Fork 133
feat: Support Exemplar #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Support Exemplar #3997
+152
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85914b7
to
1c37cf4
Compare
2c7825f
to
7f74867
Compare
d7c09ff
to
3301572
Compare
d19f669
to
de5e4b9
Compare
surbhigarg92
commented
Jul 25, 2025
google-cloud-spanner/pom.xml
Outdated
@@ -641,4 +641,4 @@ | |||
</dependencies> | |||
</profile> | |||
</profiles> | |||
</project> | |||
</project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sakthivelmanii not sure unable revert this whitespace change
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsConstant.java
Show resolved
Hide resolved
sakthivelmanii
previously approved these changes
Jul 28, 2025
sakthivelmanii
approved these changes
Jul 30, 2025
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jul 31, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.97.1` -> `6.98.0` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.98.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6980-2025-07-31) ##### Features - Proto changes for an internal api ([675e90b](googleapis/java-spanner@675e90b)) - **spanner:** A new field `snapshot_timestamp` is added to message `.google.spanner.v1.CommitResponse` ([675e90b](googleapis/java-spanner@675e90b)) - Support Exemplar ([#​3997](googleapis/java-spanner#3997)) ([fcf0a01](googleapis/java-spanner@fcf0a01)) - Use multiplex sessions for RW and Partition Ops ([#​3996](googleapis/java-spanner#3996)) ([a882204](googleapis/java-spanner@a882204)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.60.2 ([675e90b](googleapis/java-spanner@675e90b)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.50.2 ([#​4004](googleapis/java-spanner#4004)) ([986c0e0](googleapis/java-spanner@986c0e0)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e7253efcfa4f9166c7524a0c1ef8947662193d8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Exemplars in Client side metrics. Exemplars will also include
x-goog-spanner-request-id
attribute