Skip to content

feat: Support Exemplar #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 30, 2025
Merged

feat: Support Exemplar #3997

merged 8 commits into from
Jul 30, 2025

Conversation

surbhigarg92
Copy link
Contributor

@surbhigarg92 surbhigarg92 commented Jul 17, 2025

This PR adds support for Exemplars in Client side metrics. Exemplars will also include x-goog-spanner-request-id attribute

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jul 17, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 24, 2025
@surbhigarg92 surbhigarg92 force-pushed the poc_exemplars branch 2 times, most recently from 2c7825f to 7f74867 Compare July 24, 2025 13:48
@surbhigarg92 surbhigarg92 changed the title Poc exemplars feat: Support Exemplar Jul 24, 2025
@surbhigarg92 surbhigarg92 marked this pull request as ready for review July 24, 2025 13:54
@surbhigarg92 surbhigarg92 requested review from a team as code owners July 24, 2025 13:54
@surbhigarg92 surbhigarg92 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jul 25, 2025
@@ -641,4 +641,4 @@
</dependencies>
</profile>
</profiles>
</project>
</project>
Copy link
Contributor Author

@surbhigarg92 surbhigarg92 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakthivelmanii not sure unable revert this whitespace change

sakthivelmanii
sakthivelmanii previously approved these changes Jul 28, 2025
@surbhigarg92 surbhigarg92 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit fcf0a01 into main Jul 30, 2025
38 of 42 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the poc_exemplars branch July 30, 2025 11:00
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jul 31, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`6.97.1` -> `6.98.0` |

---

### Release Notes

<details>
<summary>googleapis/java-spanner
(com.google.cloud:google-cloud-spanner)</summary>

###
[`v6.98.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6980-2025-07-31)

##### Features

- Proto changes for an internal api
([675e90b](googleapis/java-spanner@675e90b))
- **spanner:** A new field `snapshot_timestamp` is added to message
`.google.spanner.v1.CommitResponse`
([675e90b](googleapis/java-spanner@675e90b))
- Support Exemplar
([#&#8203;3997](googleapis/java-spanner#3997))
([fcf0a01](googleapis/java-spanner@fcf0a01))
- Use multiplex sessions for RW and Partition Ops
([#&#8203;3996](googleapis/java-spanner#3996))
([a882204](googleapis/java-spanner@a882204))

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.60.2
([675e90b](googleapis/java-spanner@675e90b))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.50.2
([#&#8203;4004](googleapis/java-spanner#4004))
([986c0e0](googleapis/java-spanner@986c0e0))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: e7253efcfa4f9166c7524a0c1ef8947662193d8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants