fix: consistent behavior of customwalentry filter across hbase1.x and hbase2.x (#3562)

* fix: consistent behavior of customwalentry filter

* import static

* fix: proper TODO

* delete the config key

Author: sushanb

hbase-migration-tools/bigtable-hbase-replication/bigtable-hbase-2.x-replication/src/main/java/com/google/cloud/bigtable/hbase2_x/replication/HbaseToCloudBigtableReplicationEndpoint.java

@@ -17,7 +17,7 @@
 package com.google.cloud.bigtable.hbase2_x.replication;
 // TODO reverse the package names for 1.x and 2.x to com.google.cloud.bigtable.replication.hbase1_x
 
-import static com.google.cloud.bigtable.hbase.replication.configuration.HBaseToCloudBigtableReplicationConfiguration.BIGTABLE_REPLICATION_WALENTRYFILTER_CONFIG_KEY;
+import static org.apache.hadoop.hbase.replication.BaseReplicationEndpoint.REPLICATION_WALENTRYFILTER_CONFIG_KEY;
 
 import com.google.bigtable.repackaged.com.google.api.core.InternalExtensionOnly;
 import com.google.bigtable.repackaged.com.google.common.util.concurrent.AbstractService;
@@ -103,10 +103,7 @@ public WALEntryFilter getWALEntryfilter() {
     }
     if (context != null && context.getPeerConfig() != null) {
       String filterNameCSV =
-          context
-              .getPeerConfig()
-              .getConfiguration()
-              .get(BIGTABLE_REPLICATION_WALENTRYFILTER_CONFIG_KEY);
+          context.getPeerConfig().getConfiguration().get(REPLICATION_WALENTRYFILTER_CONFIG_KEY);
       if (filterNameCSV != null && !filterNameCSV.isEmpty()) {
         String[] filterNames = filterNameCSV.split(",");
         for (String filterName : filterNames) {

hbase-migration-tools/bigtable-hbase-replication/bigtable-hbase-replication-core/src/main/java/com/google/cloud/bigtable/hbase/replication/configuration/HBaseToCloudBigtableReplicationConfiguration.java

@@ -59,8 +59,4 @@ private HBaseToCloudBigtableReplicationConfiguration() {}
   // batch capacity by counts and bytes. These capacity are set by `replication.source.nb.capacity`
   // and `replication.source.size.capacity` config keys.
   public static final long DEFAULT_BATCH_SIZE_IN_BYTES = 500_000;
-  // TODO: Plumb this config key to HBase1.x
-  // Allow for config-driven WALEntryFilters for any bigtable replication peer
-  public static final String BIGTABLE_REPLICATION_WALENTRYFILTER_CONFIG_KEY =
-      "google.bigtable.replication..source.custom.walentryfilters";
 }