Skip to content

Commit 25b2af8

Browse files
feat: add ocagent exporter to shaded jars to allow customers more fle… (#3683)
…xibility for clientside metrics Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigtable-hbase/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
1 parent b67c790 commit 25b2af8

File tree

3 files changed

+51
-1
lines changed
  • bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded
  • bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded

3 files changed

+51
-1
lines changed

bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,30 @@ limitations under the License.
9999
<groupId>io.opencensus</groupId>
100100
<artifactId>opencensus-exporter-trace-stackdriver</artifactId>
101101
</dependency>
102+
<dependency>
103+
<groupId>io.opencensus</groupId>
104+
<artifactId>opencensus-exporter-metrics-ocagent</artifactId>
105+
<version>${opencensus.version}</version>
106+
<exclusions>
107+
<!-- we already use netty-shaded -->
108+
<exclusion>
109+
<groupId>io.grpc</groupId>
110+
<artifactId>grpc-netty</artifactId>
111+
</exclusion>
112+
</exclusions>
113+
</dependency>
114+
<dependency>
115+
<groupId>io.opencensus</groupId>
116+
<artifactId>opencensus-exporter-trace-ocagent</artifactId>
117+
<version>${opencensus.version}</version>
118+
<exclusions>
119+
<!-- we already use netty-shaded -->
120+
<exclusion>
121+
<groupId>io.grpc</groupId>
122+
<artifactId>grpc-netty</artifactId>
123+
</exclusion>
124+
</exclusions>
125+
</dependency>
102126
<!-- grpc-census needed alongside opencensus-exporter-stats-stackdriver for GRPC stats exports to work -->
103127
<dependency>
104128
<groupId>io.grpc</groupId>

bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,31 @@ limitations under the License.
9393
<groupId>io.opencensus</groupId>
9494
<artifactId>opencensus-exporter-trace-stackdriver</artifactId>
9595
</dependency>
96+
<dependency>
97+
<groupId>io.opencensus</groupId>
98+
<artifactId>opencensus-exporter-metrics-ocagent</artifactId>
99+
<version>${opencensus.version}</version>
100+
<exclusions>
101+
<!-- we already use netty-shaded -->
102+
<exclusion>
103+
<groupId>io.grpc</groupId>
104+
<artifactId>grpc-netty</artifactId>
105+
</exclusion>
106+
</exclusions>
107+
</dependency>
108+
<dependency>
109+
<groupId>io.opencensus</groupId>
110+
<artifactId>opencensus-exporter-trace-ocagent</artifactId>
111+
<version>${opencensus.version}</version>
112+
<exclusions>
113+
<!-- we already use netty-shaded -->
114+
<exclusion>
115+
<groupId>io.grpc</groupId>
116+
<artifactId>grpc-netty</artifactId>
117+
</exclusion>
118+
</exclusions>
119+
</dependency>
120+
96121
<!-- grpc-census needed alongside opencensus-exporter-stats-stackdriver for GRPC stats exports to work -->
97122
<dependency>
98123
<groupId>io.grpc</groupId>

pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ limitations under the License.
8383
<guava.version>31.1-jre</guava.version>
8484
<gcs-guava.version>29.0-jre</gcs-guava.version>
8585
<beam-slf4j.version>1.7.30</beam-slf4j.version>
86+
<opencensus.version>0.28.0</opencensus.version>
8687

8788
<!-- Benchmarks related dependencies -->
8889
<jmh.version>1.35</jmh.version>
@@ -318,7 +319,7 @@ limitations under the License.
318319
<!-- gax-grpc transitvely brings in opencensus-proto, which the latest version is 0.2.0-->
319320
<!-- Only allow 0.2.0 for opencensus-proto and then the latest version (currently 0.28.0) for all other modules-->
320321
<!-- this will need to be updated whenever the opencensus version gets updated -->
321-
<dependency>io.opencensus:*:[0.28.0]</dependency>
322+
<dependency>io.opencensus:*:[${opencensus.version}]</dependency>
322323
<dependency>io.opencensus:opencensus-proto:[0.2.0]</dependency>
323324
</includes>
324325
</bannedDependencies>

0 commit comments

Comments
 (0)