Skip to content

Commit 0dfb130

Browse files
fix: published dependencies of bigtable-beam-import (#3600)
Due to a bug in maven shade plugin 3.3.0, compile dependencies got stripped from bigtable-beam-import. This bug only affects artifacts where shadedArtifactAttached=true. Reference: https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419
1 parent 430686e commit 0dfb130

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ limitations under the License.
162162
<plugin>
163163
<groupId>org.apache.maven.plugins</groupId>
164164
<artifactId>maven-shade-plugin</artifactId>
165-
<version>3.3.0</version>
165+
<!-- MSHADE-419: 3.3.0 Shade plugin causes pom to be created without compile dependencies -->
166+
<version>3.2.4</version>
166167
</plugin>
167168
<plugin>
168169
<groupId>org.apache.maven.plugins</groupId>

renovate.json5

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,13 @@
8888
// pin to bigtable version
8989
"packagePatterns": ["^grpc-conscrypt.version"],
9090
"enabled": false
91+
},
92+
{
93+
"packagePatterns": [
94+
"^org.apache.maven.plugins:maven-shade-plugin"
95+
],
96+
// Exclude version 3.3.0 due to https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419
97+
"allowedVersions": "(,3.3.0),(3.3.0,)"
9198
}
9299
],
93100
"semanticCommits": true,

0 commit comments

Comments
 (0)