Skip to content

Commit c51a6a4

Browse files
author
Tomasz Los
committed
fix: extract labels to a separate contant
1 parent 9e05ca0 commit c51a6a4

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigQueryImplTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ public class BigQueryImplTest {
132132
.setField("timestampField");
133133
private static final TimePartitioning TIME_PARTITIONING_NULL_TYPE =
134134
TimePartitioning.fromPb(PB_TIMEPARTITIONING);
135+
private static final ImmutableMap<String, String> LABELS = ImmutableMap.of("key", "value");
135136
private static final StandardTableDefinition TABLE_DEFINITION_WITH_PARTITIONING =
136137
StandardTableDefinition.newBuilder()
137138
.setSchema(TABLE_SCHEMA)
@@ -156,7 +157,7 @@ public class BigQueryImplTest {
156157
private static final TableInfo TABLE_INFO = TableInfo.of(TABLE_ID, TABLE_DEFINITION);
157158
private static final TableInfo OTHER_TABLE_INFO = TableInfo.of(OTHER_TABLE_ID, TABLE_DEFINITION);
158159
private static final TableInfo OTHER_TABLE_WITH_LABELS_INFO = TableInfo.newBuilder(OTHER_TABLE_ID, TABLE_DEFINITION)
159-
.setLabels(ImmutableMap.of("key", "value"))
160+
.setLabels(LABELS)
160161
.build();
161162
private static final TableInfo TABLE_INFO_WITH_PROJECT =
162163
TableInfo.of(TABLE_ID_WITH_PROJECT, TABLE_DEFINITION);
@@ -1168,7 +1169,7 @@ public void testListTablesWithLabels() throws IOException {
11681169
assertEquals(CURSOR, page.getNextPageToken());
11691170
assertArrayEquals(tableList.toArray(), Iterables.toArray(page.getValues(), Table.class));
11701171
verify(bigqueryRpcMock).listTablesSkipExceptionTranslation(PROJECT, DATASET, EMPTY_RPC_OPTIONS);
1171-
assertEquals(ImmutableMap.of("key", "value"), page.getValues().iterator().next().getLabels());
1172+
assertEquals(LABELS, page.getValues().iterator().next().getLabels());
11721173
}
11731174

11741175
@Test

0 commit comments

Comments
 (0)